Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Text direction is wrong (RTL languages) #439

Closed
uomar8 opened this issue Feb 11, 2024 · 5 comments · Fixed by #441
Closed

Text direction is wrong (RTL languages) #439

uomar8 opened this issue Feb 11, 2024 · 5 comments · Fixed by #441
Labels
Milestone

Comments

@uomar8
Copy link
Contributor

uomar8 commented Feb 11, 2024

After version 4.0.0 Text direction is wrong it doesn't change with RTL languages

After 4.0.0
Screenshot_20240211_221009_com example android notepad_edit_1183593751902

Before:
Screenshot_20240211_221451_com example android notepad_edit_1192078985234

Another example
After 4.0.0:
Screenshot_20240211_222105_com example android notepad_edit_555959091060
Before:
Screenshot_20240211_222122_com example android notepad_edit_563088353038

Also I hope text align would be fixed
With text direction and text align it should look like this:
Project (20240211103920)

Project (20240211104011)

@uomar8
Copy link
Contributor Author

uomar8 commented Feb 11, 2024

@firemaples
Copy link
Owner

Thanks for the feedback, let me check why RTL is not working.

@firemaples firemaples added the bug label Feb 17, 2024
@uomar8
Copy link
Contributor Author

uomar8 commented Feb 17, 2024

i founded an easy fix

style = TextStyle(textDirection = TextDirection.Content),

without this line
image

with this line (Text direction is view correctly
image

@uomar8
Copy link
Contributor Author

uomar8 commented Feb 17, 2024

tired
textAlign = TextAlign.Justify

but it didn't work i hava no idea why

@firemaples
Copy link
Owner

Fixed in #441
Thank you for the investigation and fixing 🙇‍♂️

@firemaples firemaples added this to the v4.0.0 milestone Apr 6, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants