Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor: cleanup Dynamic Links example app and integration tests #5903

Merged
merged 4 commits into from
Apr 23, 2021

Conversation

Salakar
Copy link
Member

@Salakar Salakar commented Apr 23, 2021

Description

  • Added CI workflow for Dynamic Links - previously missing.
  • Fixed Android build - was looking for e2e dependency but not included on pubspec.yaml. Build would crash previously.
  • Fixed iOS build, this was completely broken by fix(dynamic_links,ios): retry handling iOS universal link on network failure #4354.
  • Added start of e2e tests using drive package.
  • Rewrote the existing integration test (that wasn't being used) to explicitly check parameters.
  • Updated Android example app to v2 Flutter embedding.

Related Issues

Replace this paragraph with a list of issues related to this PR from the issue database. Indicate, which of these issues are resolved or fixed by this PR. Note that you'll have to prefix the issue numbers with flutter/flutter#.

Checklist

Before you create this PR confirm that it meets all requirements listed below by checking the relevant checkboxes ([x]).
This will ensure a smooth and quick review process. Updating the pubspec.yaml and changelogs is not required.

  • I read the Contributor Guide and followed the process outlined there for submitting PRs.
  • My PR includes unit or integration tests for all changed/updated/fixed behaviors (See Contributor Guide).
  • All existing and new tests are passing.
  • I updated/added relevant documentation (doc comments with ///).
  • The analyzer (melos run analyze) does not report any problems on my PR.
  • I read and followed the Flutter Style Guide.
  • I signed the CLA.
  • I am willing to follow-up on review comments in a timely manner.

Breaking Change

Does your PR require plugin users to manually update their apps to accommodate your change?

  • Yes, this is a breaking change.
  • No, this is not a breaking change.

@google-cla google-cla bot added the cla: yes label Apr 23, 2021
@Salakar Salakar changed the title tests: setup firebase_dynamic_links CI test: setup firebase_dynamic_links CI Apr 23, 2021
@Salakar Salakar force-pushed the @salakar/add-dyn-links-ci branch from 6907ea2 to 0da157d Compare April 23, 2021 12:48
@Salakar Salakar changed the title test: setup firebase_dynamic_links CI refactor: cleanup Dynamic Links example app and integration tests Apr 23, 2021
@Salakar Salakar marked this pull request as ready for review April 23, 2021 13:18
@Salakar Salakar requested a review from kroikie as a code owner April 23, 2021 13:18
@Salakar Salakar removed the request for review from kroikie April 23, 2021 13:42
@Salakar Salakar merged commit 7ecff5d into master Apr 23, 2021
@Salakar Salakar deleted the @salakar/add-dyn-links-ci branch April 23, 2021 14:10
@firebase firebase locked and limited conversation to collaborators May 24, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant