-
Notifications
You must be signed in to change notification settings - Fork 4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix(dynamic_links,ios): retry handling iOS universal link on network failure #4354
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
14 tasks
Any update on this? @Salakar |
Hello @Salakar and @jherencia |
I've tested this PR and I'm unable to get a link passed through from the app store to work, unless I add a few seconds delay before checking for pending links. |
13 tasks
Salakar
reviewed
Apr 21, 2021
packages/firebase_dynamic_links/ios/Classes/FLTFirebaseDynamicLinksPlugin.m
Show resolved
Hide resolved
9052f6a
to
116ba5e
Compare
Salakar
approved these changes
Apr 23, 2021
Salakar
added a commit
that referenced
this pull request
Apr 23, 2021
10 tasks
Salakar
added a commit
that referenced
this pull request
Apr 23, 2021
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
People have posted some issues:
on iOS dynamic links behavior. All of this use cases worked before iOS 12 release so I assume Firebase update and iOS 12 have changed things.
I've based my work on the release of rn-firebase 6.0 that had the same problems and were fixed so this PR takes some ideas from them.
Related Issues
Checklist
Before you create this PR confirm that it meets all requirements listed below by checking the relevant checkboxes (
[x]
). This will ensure a smooth and quick review process.///
).flutter analyze
) does not report any problems on my PR.Breaking Change
Does your PR require plugin users to manually update their apps to accommodate your change?