Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(dynamic_links,ios): retry handling iOS universal link on network failure #4354

Merged
merged 1 commit into from
Apr 23, 2021

Conversation

jherencia
Copy link
Contributor

@jherencia jherencia commented Dec 8, 2020

Description

People have posted some issues:

I've based my work on the release of rn-firebase 6.0 that had the same problems and were fixed so this PR takes some ideas from them.

Related Issues

Checklist

Before you create this PR confirm that it meets all requirements listed below by checking the relevant checkboxes ([x]). This will ensure a smooth and quick review process.

  • I read the Contributor Guide and followed the process outlined there for submitting PRs.
  • If the pull request affects only one plugin, the PR title starts with the name of the plugin in brackets (e.g. [cloud_firestore])
  • My PR includes unit or integration tests for all changed/updated/fixed behaviors (See Contributor Guide).
  • All existing and new tests are passing.
  • I updated/added relevant documentation (doc comments with ///).
  • The analyzer (flutter analyze) does not report any problems on my PR.
  • I read and followed the Flutter Style Guide.
  • The title of the PR starts with the name of the plugin surrounded by square brackets, e.g. [shared_preferences]
  • I updated pubspec.yaml with an appropriate new version according to the pub versioning philosophy.
  • I updated CHANGELOG.md to add a description of the change.
  • I signed the CLA.
  • I am willing to follow-up on review comments in a timely manner.

Breaking Change

Does your PR require plugin users to manually update their apps to accommodate your change?

  • Yes, this is a breaking change (please indicate a breaking change in CHANGELOG.md and increment major revision).
  • No, this is not a breaking change.

@jherencia
Copy link
Contributor Author

@Salakar

This is a clone of #255 with the code updated to be mergeable.

@Salakar Salakar self-assigned this Dec 8, 2020
@himsa
Copy link

himsa commented Jan 14, 2021

Any update on this? @Salakar
I see the newest version is 0.7.0+1
is this PR merged ?

@b-jan
Copy link

b-jan commented Jan 20, 2021

Hello @Salakar and @jherencia
Can we merge this one soon?

@josh-burton
Copy link
Contributor

I've tested this PR and I'm unable to get a link passed through from the app store to work, unless I add a few seconds delay before checking for pending links.

@jherencia jherencia force-pushed the firebase_dynamic_links-i100 branch from 9052f6a to 116ba5e Compare April 23, 2021 06:46
@Salakar Salakar changed the title fix(dynamic_links): not working on app start (#100) fix(dynamic_links): retry handling universal link on network failure (#100) Apr 23, 2021
@Salakar Salakar changed the title fix(dynamic_links): retry handling universal link on network failure (#100) fix(dynamic_links): retry handling universal link on network failure Apr 23, 2021
@Salakar Salakar changed the title fix(dynamic_links): retry handling universal link on network failure fix(dynamic_links,ios): retry handling iOS universal link on network failure Apr 23, 2021
@Salakar Salakar merged commit ee442a9 into firebase:master Apr 23, 2021
Salakar added a commit that referenced this pull request Apr 23, 2021
Salakar added a commit that referenced this pull request Apr 23, 2021
@firebase firebase locked and limited conversation to collaborators May 24, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Projects
None yet
5 participants