Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[firebase_admob] Provide a default MobileAdTargetingInfo for RewardedVideoAd.load() #2245

Merged
merged 9 commits into from
Apr 24, 2020
Merged

[firebase_admob] Provide a default MobileAdTargetingInfo for RewardedVideoAd.load() #2245

Show file tree
Hide file tree
Changes from 3 commits
Commits
Show all changes
9 commits
Select commit Hold shift + click to select a range
ad71ae7
Provide a default MobileAdTargetingInfo for RewardedVideoAd.load()
kunny Mar 27, 2020
1151218
Add a test for RewardedVideoAd
kunny Mar 31, 2020
898a68b
Reformat code
kunny Mar 31, 2020
313ff11
version bump
bparrishMines Apr 2, 2020
8d33eea
empty test commit
bparrishMines Apr 2, 2020
7e76304
Try only testing load start
bparrishMines Apr 9, 2020
567dc50
Make test a driver test
bparrishMines Apr 23, 2020
13ced7e
Merge branch 'master' of github.com:FirebaseExtended/flutterfire into…
bparrishMines Apr 23, 2020
207ac77
Fix iOS scripts
bparrishMines Apr 24, 2020
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 2 additions & 1 deletion packages/firebase_admob/lib/firebase_admob.dart
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -489,7 +489,8 @@ class RewardedVideoAd {

/// Loads a rewarded video ad using the provided ad unit ID.
Future<bool> load(
{@required String adUnitId, MobileAdTargetingInfo targetingInfo}) {
{@required String adUnitId,
MobileAdTargetingInfo targetingInfo = const MobileAdTargetingInfo()}) {
assert(adUnitId.isNotEmpty);
return _invokeBooleanMethod("loadRewardedVideoAd", <String, dynamic>{
'adUnitId': adUnitId,
Expand Down
29 changes: 29 additions & 0 deletions packages/firebase_admob/test/firebase_admob_e2e.dart
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -13,6 +13,35 @@ void main() {
);
});

testWidgets('Rewarded Video Ads', (WidgetTester tester) async {
bool adLoaded = false;

RewardedVideoAd.instance.listener =
(RewardedVideoAdEvent event, {int rewardAmount, String rewardType}) {
if (event == RewardedVideoAdEvent.loaded) adLoaded = true;
};

// Request without a targeting info
await RewardedVideoAd.instance.load(adUnitId: RewardedVideoAd.testAdUnitId);
await Future<void>.delayed(Duration(seconds: 10));
expect(adLoaded, isTrue);

adLoaded = false;

// Request with a targeting info
await RewardedVideoAd.instance.load(
adUnitId: RewardedVideoAd.testAdUnitId,
targetingInfo: MobileAdTargetingInfo(
keywords: <String>['foo', 'bar'],
contentUrl: 'http://foo.com/bar.html',
childDirected: true,
nonPersonalizedAds: true,
),
);
await Future<void>.delayed(Duration(seconds: 10));
expect(adLoaded, isTrue);
});

testWidgets('Native Ads', (WidgetTester tester) async {
bool adLoaded = false;

Expand Down