-
Notifications
You must be signed in to change notification settings - Fork 4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[firebase_admob] Provide a default MobileAdTargetingInfo for RewardedVideoAd.load() #2245
[firebase_admob] Provide a default MobileAdTargetingInfo for RewardedVideoAd.load() #2245
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Everything looks good. We just need a test for this? You could probably just add a test in firebase_admob_e2e.dart that makes sure that calling load()
without targetingInfo doesn't cause a crash.
@bparrishMines Added a test for RrewardedVideoAd. Please review and let me know whether it's okay or not. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Thanks for adding tests! I bumped the version and will merge once the analyze tests pass again.
It looks like the integration tests have stopped passing after I added the version bump. They haven't passed after re-runnning them either. I'll try and see if I can get them to pass before merging. |
… kunny/fix_admob_rewarded_targetinginfo
I'm going to go ahead and merge this since the failing tests seem to be flaking in PRs. I'll revert if this doesn't pass the test on master. |
Description
Provides a default
MobileAdTargetingInfo
forRewardedVideoAd.load()
method to be aligned withMobileAd
's implementation as follows:Related Issues
Checklist
Before you create this PR confirm that it meets all requirements listed below by checking the relevant checkboxes (
[x]
). This will ensure a smooth and quick review process.///
).flutter analyze
) does not report any problems on my PR.Breaking Change
Does your PR require plugin users to manually update their apps to accommodate your change?