Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[firebase_admob] Provide a default MobileAdTargetingInfo for RewardedVideoAd.load() #2245

Merged
merged 9 commits into from
Apr 24, 2020

Conversation

kunny
Copy link
Contributor

@kunny kunny commented Mar 27, 2020

Description

Provides a default MobileAdTargetingInfo for RewardedVideoAd.load() method to be aligned with MobileAd's implementation as follows:

abstract class MobileAd {
  /// Default constructor, used by subclasses.
  MobileAd({
    @required this.adUnitId,
    MobileAdTargetingInfo targetingInfo,
    this.listener,
  }) : _targetingInfo = targetingInfo ?? const MobileAdTargetingInfo() {
    assert(adUnitId != null && adUnitId.isNotEmpty);
    assert(_allAds[id] == null);
    _allAds[id] = this;
  }
...

Related Issues

Checklist

Before you create this PR confirm that it meets all requirements listed below by checking the relevant checkboxes ([x]). This will ensure a smooth and quick review process.

  • I read the Contributor Guide and followed the process outlined there for submitting PRs.
  • If the pull request affects only one plugin, the PR title starts with the name of the plugin in brackets (e.g. [cloud_firestore])
  • My PR includes unit or integration tests for all changed/updated/fixed behaviors (See Contributor Guide).
  • All existing and new tests are passing.
  • I updated/added relevant documentation (doc comments with ///).
  • The analyzer (flutter analyze) does not report any problems on my PR.
  • I read and followed the Flutter Style Guide.
  • I updated pubspec.yaml with an appropriate new version according to the pub versioning philosophy.
  • I updated CHANGELOG.md to add a description of the change.
  • I signed the CLA.
  • I am willing to follow-up on review comments in a timely manner.

Breaking Change

Does your PR require plugin users to manually update their apps to accommodate your change?

  • Yes, this is a breaking change (please indicate a breaking change in CHANGELOG.md and increment major revision).
  • No, this is not a breaking change.

@bparrishMines bparrishMines self-requested a review March 30, 2020 15:54
Copy link
Contributor

@bparrishMines bparrishMines left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Everything looks good. We just need a test for this? You could probably just add a test in firebase_admob_e2e.dart that makes sure that calling load() without targetingInfo doesn't cause a crash.

@kunny
Copy link
Contributor Author

kunny commented Apr 1, 2020

@bparrishMines Added a test for RrewardedVideoAd. Please review and let me know whether it's okay or not.

Copy link
Contributor

@bparrishMines bparrishMines left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Thanks for adding tests! I bumped the version and will merge once the analyze tests pass again.

@kunny kunny requested a review from amirh as a code owner April 2, 2020 21:26
@bparrishMines
Copy link
Contributor

It looks like the integration tests have stopped passing after I added the version bump. They haven't passed after re-runnning them either. I'll try and see if I can get them to pass before merging.

@bparrishMines
Copy link
Contributor

I'm going to go ahead and merge this since the failing tests seem to be flaking in PRs. I'll revert if this doesn't pass the test on master.

@bparrishMines bparrishMines merged commit 3d620ec into firebase:master Apr 24, 2020
@firebase firebase locked and limited conversation to collaborators Aug 1, 2020
@kunny kunny deleted the fix_admob_rewarded_targetinginfo branch August 14, 2020 20:36
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants