Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Upgrade two more download-artifact v3 actions to v4 in Firestore workflow #8706

Merged
merged 2 commits into from
Jan 14, 2025

Conversation

DellaBitta
Copy link
Contributor

Discussion

There were a pair of download-artifact GitHub actions that were still set to v3 instead of v4. The v3 actions were unable to find the build archive in the test-changed-firestore workflow. This PR upgrades those to v4 actions.

For an example of this failure, check this CI run.

Testing

CI.

API Changes

N/A.

@DellaBitta DellaBitta requested a review from a team as a code owner January 14, 2025 20:28
Copy link

changeset-bot bot commented Jan 14, 2025

⚠️ No Changeset found

Latest commit: 5344133

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@google-oss-bot
Copy link
Contributor

google-oss-bot commented Jan 14, 2025

@DellaBitta DellaBitta changed the title Upgraded two download-artifact v3 actions in Firestore workflow Upgrade two more download-artifact v3 actions to v4 in Firestore workflow Jan 14, 2025
@google-oss-bot
Copy link
Contributor

google-oss-bot commented Jan 14, 2025

Copy link
Contributor

@hsubox76 hsubox76 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I guess it wasn't caught by the Renovate PR #8128 because that PR was originally created in April and last updated in May, and Daniel added these jobs in October?

@DellaBitta DellaBitta merged commit 0b318a9 into main Jan 14, 2025
50 checks passed
@DellaBitta DellaBitta deleted the ddb-fix-firestore-workflow branch January 14, 2025 23:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants