Skip to content

Commit

Permalink
Upgrade two more download-artifact v3 actions to v4 in Firestore wo…
Browse files Browse the repository at this point in the history
…rkflow (#8706)

There were a pair of `download-artifact` GitHub actions that were still set to `v3` instead of `v4`. The `v3` actions were unable to find the build archive in the test-changed-firestore workflow. This PR upgrades those to `v4` actions.
  • Loading branch information
DellaBitta authored Jan 14, 2025
1 parent 21164c2 commit 0b318a9
Show file tree
Hide file tree
Showing 2 changed files with 4 additions and 4 deletions.
4 changes: 2 additions & 2 deletions .github/workflows/test-changed-firestore.yml
Original file line number Diff line number Diff line change
Expand Up @@ -232,7 +232,7 @@ jobs:
with:
node-version: 22.10.0
- name: Download build archive
uses: actions/download-artifact@v3
uses: actions/download-artifact@v4
with:
name: build.tar.gz
- name: Unzip build artifact
Expand All @@ -259,7 +259,7 @@ jobs:
if: ${{ needs.build.outputs.changed == 'true'}}
steps:
- name: Download build archive
uses: actions/download-artifact@v3
uses: actions/download-artifact@v4
with:
name: build.tar.gz
- name: Unzip build artifact
Expand Down
4 changes: 2 additions & 2 deletions config/karma.base.js
Original file line number Diff line number Diff line change
Expand Up @@ -54,8 +54,8 @@ const config = {
// Doing 65 seconds to allow for the 20 second firestore tests
browserNoActivityTimeout: 65000,

// preprocess matching files before serving them to the browser
// available preprocessors:
// Preprocess matching files before serving them to the browser.
// Available preprocessors:
// https://npmjs.org/browse/keyword/karma-preprocessor
preprocessors: {
'test/**/*.ts': ['webpack', 'sourcemap'],
Expand Down

0 comments on commit 0b318a9

Please sign in to comment.