Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

#58: Fixing languages #59

Merged
merged 1 commit into from
Apr 2, 2020
Merged

#58: Fixing languages #59

merged 1 commit into from
Apr 2, 2020

Conversation

pbrudnick
Copy link
Member

  • Calculate the total of lang % using the aggregation of org lang %.
  • Get rid of bytes where it is not needed. (bytes are only used to calculate % in github backend)
  • Fix the index chart with the languages accumulating the org percentages

@pbrudnick pbrudnick requested a review from diegomanuel April 2, 2020 03:25
diegomanuel
diegomanuel approved these changes Apr 2, 2020
View reviewed changes
Copy link
Member

@diegomanuel diegomanuel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Greattt! 🎉

@pbrudnick pbrudnick merged commit e8584ac into master Apr 2, 2020
@diegomanuel diegomanuel linked an issue Apr 2, 2020 that may be closed by this pull request
Wrong Languages % in the index chart #58
Closed
@diegomanuel diegomanuel deleted the 58_fix_languages branch April 2, 2020 21:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@diegomanuel diegomanuel diegomanuel approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Wrong Languages % in the index chart
2 participants
@pbrudnick @diegomanuel