Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Wrong Languages % in the index chart #58

Closed
pbrudnick opened this issue Apr 1, 2020 · 0 comments · Fixed by #59
Closed

Wrong Languages % in the index chart #58

pbrudnick opened this issue Apr 1, 2020 · 0 comments · Fixed by #59
Assignees
Labels
bug Something isn't working

Comments

@pbrudnick
Copy link
Member

There's a bug with the languages percentage for all the orgs (/api/languages):

  1. The calculation is being done with bytes, we should use the sum of org percentages.
    So, it does not affect if there is a repo with a LOT of bytes of one language, instead of the percentage of that language in the org.
  2. The GitLab API retrieves language percentages and not bytes, so the number of bytes couldn't be used to calculate totals anymore.

Proposed solution:

  • Calculate the total of lang % using the aggregation of org lang %.
  • Get rid of bytes where it is not needed.
  • Fix the index chart with the languages accumulating the org percentages (it will be impacted in react models, etc)
@pbrudnick pbrudnick added the bug Something isn't working label Apr 1, 2020
@pbrudnick pbrudnick self-assigned this Apr 1, 2020
@diegomanuel diegomanuel linked a pull request Apr 2, 2020 that will close this issue
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants