Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove workaround for skip-set #51

Closed
sebpuetz opened this issue Aug 28, 2019 · 2 comments · Fixed by #60
Closed

Remove workaround for skip-set #51

sebpuetz opened this issue Aug 28, 2019 · 2 comments · Fixed by #60
Assignees
@sebpuetz
Labels
bug Something isn't working maintenance
Milestone
release-0.5

Comments

@sebpuetz
Copy link
Member

Once PyO3/pyo3@ac28a31 is released, we should remove the workaround for embedding_similarity introduced in #45.
@sebpuetz sebpuetz self-assigned this Aug 28, 2019
@sebpuetz sebpuetz mentioned this issue Aug 28, 2019
Closed
@danieldk danieldk added this to the Release 0.5 milestone Sep 4, 2019
@danieldk danieldk added bug Something isn't working maintenance labels Sep 4, 2019
@sebpuetz
Copy link
Member Author

sebpuetz commented Sep 4, 2019

Looks like we're getting pyo3 0.8 soon: PyO3/pyo3#586. So chances are we'll have to make some other adjustments, too.

@sebpuetz
Copy link
Member Author

sebpuetz commented Sep 6, 2019

0.8 is out, but now we're blocked by PyO3/rust-numpy#111, since rust-numpy and finalfusion-python depend on different pyo3s

@sebpuetz sebpuetz mentioned this issue Sep 7, 2019
Merged
sebpuetz added a commit that referenced this issue Sep 7, 2019
@sebpuetz
Fix FromPyObject for SkipSet.
5397d7f 
Fixes #51 by allowing all string-iterables in FromPyObject
implementation for SkipSet.
sebpuetz added a commit that referenced this issue Sep 7, 2019
@sebpuetz
Fix FromPyObject for SkipSet.
8022cf5 
Fixes #51 by allowing all string-iterables in FromPyObject
implementation for SkipSet.
sebpuetz added a commit that referenced this issue Sep 8, 2019
@sebpuetz
Fix FromPyObject for SkipSet.
418678e 
Fixes #51 by allowing all string-iterables in FromPyObject
implementation for SkipSet.
@sebpuetz sebpuetz mentioned this issue Sep 8, 2019
Merged
danieldk pushed a commit that referenced this issue Sep 8, 2019
@sebpuetz
Fix FromPyObject for SkipSet.
680505f 
Fixes #51 by allowing all string-iterables in FromPyObject
implementation for SkipSet.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@sebpuetz sebpuetz

Labels
bug Something isn't working maintenance
Milestone
release-0.5
Development

Successfully merging a pull request may close this issue.

Fix FromPyObject for SkipSet. finalfusion/finalfusion-python
2 participants
@danieldk @sebpuetz