Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Release 0.5 #52

Closed
sebpuetz opened this issue Aug 28, 2019 · 5 comments
Closed

Release 0.5 #52

sebpuetz opened this issue Aug 28, 2019 · 5 comments
Assignees

Comments

@sebpuetz
Copy link
Member

We have added quite some features in the last month, e.g. the read methods for other formats, exposure of subword indices and the embedding similarity method.

Once #51 is done we could cut a new release, unless there is something else in the pipeline for the Python bindings.

What do you think?

@danieldk
Copy link
Member

Agreed, once there is a new PyO3 and #51 can be solved, we could branch.

@danieldk
Copy link
Member

danieldk commented Aug 29, 2019

Another question is: when do we release the 1.0? Also of finalfusion-rust. With this I am a bit worried that PyO3 changes may break an API (maybe we should wait until PyO3 1.0). But it would be good in both cases to have a stable API that we promise not to break. I'll make an issue in finalfusion-rust.

@danieldk
Copy link
Member

danieldk commented Sep 4, 2019

Oh, maybe it would be nice to have support for memory-mapped quantized arrays as well. I will try to implement WriteChunk for mmap'ed quantized arrays today as well. We could then cut a new release of finalfusion-rust soonish and then base finalfusion-python 0.5 on that.

@danieldk danieldk changed the title Realease 0.5 Release 0.5 Sep 4, 2019
@danieldk
Copy link
Member

danieldk commented Sep 4, 2019

I have created a milestone for 0.5, since this allows us to track the blocking issues:

https://github.com/finalfusion/finalfusion-python/milestone/1

@danieldk danieldk closed this as completed Sep 4, 2019
@danieldk
Copy link
Member

I am doing a final build test on AppVeyor, to check that the Windows wheels are built successfully. If so, I will branch 0.5 and tag 0.5.0.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

No branches or pull requests

3 participants