Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Catch Interrupt #85

Merged
merged 1 commit into from
Oct 25, 2021
Merged

Catch Interrupt #85

merged 1 commit into from
Oct 25, 2021

Conversation

gsquire
Copy link
Contributor

@gsquire gsquire commented Oct 23, 2021 •
edited
Loading

This patch catches the interrupt signal and returns a zero exit code. I created a test WASM script from this repository and checked the status code after adding this patch.

If you feel like this is an acceptable PR, could you please add a hacktoberfest-accepted label?

Closes #73

@gsquire
Catch Interrupt
3f4348e 
This patch catches the interrupt signal and returns a zero exit code.
cratelyn
cratelyn approved these changes Oct 25, 2021
View reviewed changes
Copy link
Contributor

@cratelyn cratelyn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

and today i learned about tokio::signal::ctrl_c 😻

thanks so much @gsquire! this is a very welcome contribution ✨

@cratelyn cratelyn merged commit 35ea531 into fastly:main Oct 25, 2021
@gsquire gsquire deleted the exit-code branch October 30, 2021 04:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@cratelyn cratelyn cratelyn approved these changes

Assignees
No one assigned
Labels
hacktoberfest-accepted
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Viceroy exits with a nonzero status code on ctrl-C
2 participants
@gsquire @cratelyn