Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Viceroy exits with a nonzero status code on ctrl-C #73

Closed
peterbourgon opened this issue Sep 9, 2021 · 0 comments · Fixed by #85
Closed

Viceroy exits with a nonzero status code on ctrl-C #73

peterbourgon opened this issue Sep 9, 2021 · 0 comments · Fixed by #85

Comments

@peterbourgon
Copy link

peterbourgon commented Sep 9, 2021

ugh /tmp/demo-app ~/Library/ApplicationSupport/fastly/viceroy -V
viceroy 0.2.4

ugh /tmp/demo-app ~/Library/ApplicationSupport/fastly/viceroy --config fastly.toml main.wasm
Sep 09 23:28:19.458  INFO checking if backend 'httpbin' is up
Sep 09 23:28:20.042  INFO backend 'httpbin' is up
Sep 09 23:28:20.043  INFO Listening on http://127.0.0.1:7878
^C

ugh /tmp/demo-app echo $status
130

This causes fastly compute serve to interpret a normal execution as having errored, which prints a big red message that is scary and bad 😨 and also not really true I guess? See fastly/cli#400.

tl;dr: Viceroy should return exit code 0 on ctrl-C/SIGINT

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant