Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fill downstream_client_request_id in #282

Merged
merged 1 commit into from
Jun 28, 2023

Conversation

fgsch
Copy link
Member

@fgsch fgsch commented Jun 28, 2023

Instead of returning an empty string, use the request id to mimic prod closer.
Prompted by @GeeWee in #276.

Instead of returning an empty string, use the request id to mimic prod closer.
Prompted by @GeeWee in #276.
@fgsch fgsch marked this pull request as ready for review June 28, 2023 10:27
@GeeWee
Copy link
Contributor

GeeWee commented Jun 28, 2023

Yay, thanks!

Copy link
Contributor

@acfoltzer acfoltzer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks good, thank you!

@acfoltzer acfoltzer merged commit fab959d into main Jun 28, 2023
@acfoltzer acfoltzer deleted the fgsch/improve-client_request_id branch June 28, 2023 16:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants