Add a stub for downstream_client_request_id #276
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
aturon
reviewed
Jun 14, 2023
Prompted by @aturon.
aturon
approved these changes
Jun 14, 2023
|
I realize I'm a little late, but is there no chance we can return a UUID or something that mimicks what you might get in live environments a little closer? |
|
@GeeWee we probably can but do you really need some value or checking for None would suffice? |
|
I mean I can live with whatever, but currently I generate a UUID for correlation logs, and I use that in e.g. integration test scenarios where I use viceroy to correlate logs from parallel requests. I was hoping to just discard that machinery and switch over to the downstream client ID if possible. |
acfoltzer
pushed a commit
that referenced
this pull request
Jun 28, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds a stub for downstream_client_request_id to avoid crashing Viceroy.
I'm not sure if it'd be better to return something meaningful. Open to suggestions.