Decouple AggregationFuzzer from DuckDB #6701
Conversation
✅ Deploy Preview for meta-velox canceled.
|
facebook-github-bot
added
the
CLA Signed
|
@mbasmanova has imported this pull request. If you are a Meta employee, you can view this diff on Phabricator. |
| */ | ||
| #pragma once | ||
|
|
||
| #include "velox/exec/tests/utils/QueryAssertions.h" |
There was a problem hiding this comment.
Consider moving this include to the DuckQueryRunner.cpp file.
You must forward-declare or use only the required std headers.
There was a problem hiding this comment.
The reason is that when you build the PrestoQueryRunner later, this include will enforce a dependency on DuckDB.
There was a problem hiding this comment.
@majetideepak These are good points. Thanks. Updated.
mbasmanova
force-pushed
the
reference-query-runner
branch
from
e77fba3 to
cf857c7
Compare
|
@mbasmanova has imported this pull request. If you are a Meta employee, you can view this diff on Phabricator. |
mbasmanova
force-pushed
the
reference-query-runner
branch
6 times, most recently
from
c860e86 to
b0b1af9
Compare
mbasmanova
force-pushed
the
reference-query-runner
branch
from
b0b1af9 to
f9d7e3e
Compare
|
@mbasmanova has imported this pull request. If you are a Meta employee, you can view this diff on Phabricator. |
mbasmanova
force-pushed
the
reference-query-runner
branch
from
f9d7e3e to
50ee13a
Compare
|
@mbasmanova has imported this pull request. If you are a Meta employee, you can view this diff on Phabricator. |
mbasmanova
force-pushed
the
reference-query-runner
branch
from
50ee13a to
efe0994
Compare
|
@mbasmanova has imported this pull request. If you are a Meta employee, you can view this diff on Phabricator. |
| return true; | ||
| } | ||
|
|
||
| std::unordered_set<std::string> getAggregateFunctions() { |
Summary: Extract ReferenceQueryRunner interface to allow using different reference databases for results verification in AggregationFuzzer. For example, we would want to verify Presto functions against Presto and Spark functions against Spark. Part of facebookincubator#6595 Reviewed By: xiaoxmeng Differential Revision: D49553797 Pulled By: mbasmanova
mbasmanova
force-pushed
the
reference-query-runner
branch
from
efe0994 to
9bb7b8c
Compare
|
This pull request was exported from Phabricator. Differential Revision: D49553797 |
|
@mbasmanova merged this pull request in cdfcd93. |
|
Conbench analyzed the 1 benchmark run on commit There were no benchmark performance regressions. 🎉 The full Conbench report has more details. |
Summary: Extract ReferenceQueryRunner interface to allow using different reference databases for results verification in AggregationFuzzer. For example, we would want to verify Presto functions against Presto and Spark functions against Spark. Part of facebookincubator#6595 Pull Request resolved: facebookincubator#6701 Reviewed By: xiaoxmeng Differential Revision: D49553797 Pulled By: mbasmanova fbshipit-source-id: 489cd41ce4276c2d1d5230780f76439a39e70456
Extract ReferenceQueryRunner interface to allow using different reference
databases for results verification in AggregationFuzzer. For example, we would
want to verify Presto functions against Presto and Spark functions against
Spark.
Part of #6595