-
Notifications
You must be signed in to change notification settings - Fork 1.2k
Commit
This commit does not belong to any branch on this repository, and may belong to a fork outside of the repository.
Decouple AggregationFuzzer from DuckDB
- Loading branch information
1 parent
bc33609
commit 50ee13a
Showing
9 changed files
with
438 additions
and
222 deletions.
There are no files selected for viewing
Large diffs are not rendered by default.
Oops, something went wrong.
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,238 @@ | ||
| /* | ||
| * Copyright (c) Facebook, Inc. and its affiliates. | ||
| * | ||
| * Licensed under the Apache License, Version 2.0 (the "License"); | ||
| * you may not use this file except in compliance with the License. | ||
| * You may obtain a copy of the License at | ||
| * | ||
| * http://www.apache.org/licenses/LICENSE-2.0 | ||
| * | ||
| * Unless required by applicable law or agreed to in writing, software | ||
| * distributed under the License is distributed on an "AS IS" BASIS, | ||
| * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. | ||
| * See the License for the specific language governing permissions and | ||
| * limitations under the License. | ||
| */ | ||
| #include "velox/exec/tests/utils/DuckQueryRunner.h" | ||
| #include "velox/exec/tests/utils/QueryAssertions.h" | ||
|
|
||
| namespace facebook::velox::exec::test { | ||
|
|
||
| namespace { | ||
|
|
||
| void appendComma(int32_t i, std::stringstream& sql) { | ||
| if (i > 0) { | ||
| sql << ", "; | ||
| } | ||
| } | ||
|
|
||
| std::string toCallSql(const core::CallTypedExprPtr& call) { | ||
| std::stringstream sql; | ||
| sql << call->name() << "("; | ||
| for (auto i = 0; i < call->inputs().size(); ++i) { | ||
| appendComma(i, sql); | ||
| sql << std::dynamic_pointer_cast<const core::FieldAccessTypedExpr>( | ||
| call->inputs()[i]) | ||
| ->name(); | ||
| } | ||
| sql << ")"; | ||
| return sql.str(); | ||
| } | ||
|
|
||
| bool isSupported(const TypePtr& type) { | ||
| // DuckDB doesn't support nanosecond precision for timestamps. | ||
| if (type->kind() == TypeKind::TIMESTAMP) { | ||
| return false; | ||
| } | ||
| for (auto i = 0; i < type->size(); ++i) { | ||
| if (!isSupported(type->childAt(i))) { | ||
| return false; | ||
| } | ||
| } | ||
|
|
||
| return true; | ||
| } | ||
|
|
||
| std::unordered_set<std::string> getAggregateFunctions() { | ||
| std::string sql = | ||
| "SELECT distinct on(function_name) function_name " | ||
| "FROM duckdb_functions() " | ||
| "WHERE function_type = 'aggregate'"; | ||
|
|
||
| DuckDbQueryRunner queryRunner; | ||
| auto result = queryRunner.executeOrdered(sql, ROW({VARCHAR()})); | ||
|
|
||
| std::unordered_set<std::string> names; | ||
| for (const auto& row : result) { | ||
| names.insert(row[0].value<std::string>()); | ||
| } | ||
|
|
||
| return names; | ||
| } | ||
| } // namespace | ||
|
|
||
| DuckQueryRunner::DuckQueryRunner() | ||
| : aggregateFunctionNames_{getAggregateFunctions()} {} | ||
|
|
||
| std::multiset<std::vector<velox::variant>> DuckQueryRunner::execute( | ||
| const std::string& sql, | ||
| const std::vector<RowVectorPtr>& input, | ||
| const RowTypePtr& resultType) { | ||
| DuckDbQueryRunner queryRunner; | ||
| queryRunner.createTable("tmp", input); | ||
| return queryRunner.execute(sql, resultType); | ||
| } | ||
|
|
||
| std::optional<std::string> DuckQueryRunner::toSql( | ||
| const core::PlanNodePtr& plan) { | ||
| if (!isSupported(plan->outputType())) { | ||
| return std::nullopt; | ||
| } | ||
|
|
||
| for (const auto& source : plan->sources()) { | ||
| if (!isSupported(source->outputType())) { | ||
| return std::nullopt; | ||
| } | ||
| } | ||
|
|
||
| if (auto projectNode = | ||
| std::dynamic_pointer_cast<const core::ProjectNode>(plan)) { | ||
| return toSql(projectNode); | ||
| } | ||
|
|
||
| if (auto windowNode = | ||
| std::dynamic_pointer_cast<const core::WindowNode>(plan)) { | ||
| return toSql(windowNode); | ||
| } | ||
|
|
||
| if (auto aggregationNode = | ||
| std::dynamic_pointer_cast<const core::AggregationNode>(plan)) { | ||
| return toSql(aggregationNode); | ||
| } | ||
|
|
||
| VELOX_NYI(); | ||
| } | ||
|
|
||
| std::optional<std::string> DuckQueryRunner::toSql( | ||
| const std::shared_ptr<const core::AggregationNode>& aggregationNode) { | ||
| // Assume plan is Aggregation over Values. | ||
| VELOX_CHECK(aggregationNode->step() == core::AggregationNode::Step::kSingle); | ||
|
|
||
| for (const auto& agg : aggregationNode->aggregates()) { | ||
| if (aggregateFunctionNames_.count(agg.call->name()) == 0) { | ||
| return std::nullopt; | ||
| } | ||
| } | ||
|
|
||
| std::vector<std::string> groupingKeys; | ||
| for (const auto& key : aggregationNode->groupingKeys()) { | ||
| groupingKeys.push_back(key->name()); | ||
| } | ||
|
|
||
| std::stringstream sql; | ||
| sql << "SELECT " << folly::join(", ", groupingKeys); | ||
|
|
||
| const auto& aggregates = aggregationNode->aggregates(); | ||
| if (!aggregates.empty()) { | ||
| if (!groupingKeys.empty()) { | ||
| sql << ", "; | ||
| } | ||
|
|
||
| for (auto i = 0; i < aggregates.size(); ++i) { | ||
| appendComma(i, sql); | ||
| const auto& aggregate = aggregates[i]; | ||
| sql << toCallSql(aggregate.call); | ||
|
|
||
| if (aggregate.mask != nullptr) { | ||
| sql << " filter (where " << aggregate.mask->name() << ")"; | ||
| } | ||
| sql << " as " << aggregationNode->aggregateNames()[i]; | ||
| } | ||
| } | ||
|
|
||
| sql << " FROM tmp"; | ||
|
|
||
| if (!groupingKeys.empty()) { | ||
| sql << " GROUP BY " << folly::join(", ", groupingKeys); | ||
| } | ||
|
|
||
| return sql.str(); | ||
| } | ||
|
|
||
| std::optional<std::string> DuckQueryRunner::toSql( | ||
| const std::shared_ptr<const core::ProjectNode>& projectNode) { | ||
| auto sourceSql = toSql(projectNode->sources()[0]); | ||
| if (!sourceSql.has_value()) { | ||
| return std::nullopt; | ||
| } | ||
|
|
||
| std::stringstream sql; | ||
| sql << "SELECT "; | ||
|
|
||
| for (auto i = 0; i < projectNode->names().size(); ++i) { | ||
| appendComma(i, sql); | ||
| auto projection = projectNode->projections()[i]; | ||
| if (auto field = | ||
| std::dynamic_pointer_cast<const core::FieldAccessTypedExpr>( | ||
| projection)) { | ||
| sql << field->name(); | ||
| } else if ( | ||
| auto call = | ||
| std::dynamic_pointer_cast<const core::CallTypedExpr>(projection)) { | ||
| sql << toCallSql(call); | ||
| } else { | ||
| VELOX_NYI(); | ||
| } | ||
|
|
||
| sql << " as " << projectNode->names()[i]; | ||
| } | ||
|
|
||
| sql << " FROM (" << sourceSql.value() << ")"; | ||
| return sql.str(); | ||
| } | ||
|
|
||
| std::optional<std::string> DuckQueryRunner::toSql( | ||
| const std::shared_ptr<const core::WindowNode>& windowNode) { | ||
| std::stringstream sql; | ||
| sql << "SELECT "; | ||
|
|
||
| const auto& inputType = windowNode->sources()[0]->outputType(); | ||
| for (auto i = 0; i < inputType->size(); ++i) { | ||
| appendComma(i, sql); | ||
| sql << inputType->nameOf(i); | ||
| } | ||
|
|
||
| sql << ", "; | ||
|
|
||
| const auto& functions = windowNode->windowFunctions(); | ||
| for (auto i = 0; i < functions.size(); ++i) { | ||
| appendComma(i, sql); | ||
| sql << toCallSql(functions[i].functionCall); | ||
| } | ||
| sql << " OVER ("; | ||
|
|
||
| const auto& partitionKeys = windowNode->partitionKeys(); | ||
| if (!partitionKeys.empty()) { | ||
| sql << "partition by "; | ||
| for (auto i = 0; i < partitionKeys.size(); ++i) { | ||
| appendComma(i, sql); | ||
| sql << partitionKeys[i]->name(); | ||
| } | ||
| } | ||
|
|
||
| const auto& sortingKeys = windowNode->sortingKeys(); | ||
| const auto& sortingOrders = windowNode->sortingOrders(); | ||
|
|
||
| if (!sortingKeys.empty()) { | ||
| sql << " order by "; | ||
| for (auto i = 0; i < sortingKeys.size(); ++i) { | ||
| appendComma(i, sql); | ||
| sql << sortingKeys[i]->name() << " " << sortingOrders[i].toString(); | ||
| } | ||
| } | ||
|
|
||
| sql << ") FROM tmp"; | ||
|
|
||
| return sql.str(); | ||
| } | ||
| } // namespace facebook::velox::exec::test |
Oops, something went wrong.