Fix codegen CMakeLists.txt #26
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
facebook-github-bot
added
the
CLA Signed
|
@christycylee has imported this pull request. If you are a Facebook employee, you can view this diff on Phabricator. |
Summary: velox/experimental/codegen did not have its CMakeLists.txt set up properly, so some tests weren't ran when building with cmake. I had to disable one test, that will be addressed in the future. Pull Request resolved: facebookincubator/velox#26 Reviewed By: kkeita Differential Revision: D30262438 Pulled By: christycylee fbshipit-source-id: 2583fd8c93a0ee423c31f23e10e9c006ac3a6543
christycylee
force-pushed
the
codegen_cmake_files
branch
from
00d8985 to
67bf403
Compare
|
This pull request was exported from Phabricator. Differential Revision: D30262438 |
|
@christycylee merged this pull request in 100e574. |
facebook-github-bot
pushed a commit
that referenced
this pull request
Feb 9, 2022
Summary: Pull Request resolved: facebookexperimental/rust-shed#26 Pull Request resolved: facebook/sapling#104 No need for the checked in generated code anymore Successful external CI Linux run on Git Hub PR: https://github.com/facebookexperimental/eden/runs/5130405984?check_suite_focus=true Mac PR run fails with a SSL cert issue, will look separately Reviewed By: chadaustin, mitrandir77 Differential Revision: D33840545 fbshipit-source-id: eafc2a0e2191d438fd828adeebc2e318d319025f
bdice
pushed a commit
to bdice/velox
that referenced
this pull request
Dec 19, 2024
…nterop_cudf Use arrow interop for cudf-velox conversion
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
velox/experimental/codegen did not have its CMakeLists.txt set up properly, so some tests weren't ran when building with cmake. I had to disable one test, that will be addressed in the future.