remove generated thrift code (#104) #26
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Summary: Pull Request resolved: facebook/sapling#104 No need for the checked in generated code anymore Reviewed By: chadaustin Differential Revision: D33840545 fbshipit-source-id: 4ed4a9b1bb7d850d3f3e047f88bcdbc326f70a4c
facebook-github-bot
added
CLA Signed
|
This pull request was exported from Phabricator. Differential Revision: D33840545 |
ahornby
added a commit
to ahornby/sapling
that referenced
this pull request
Feb 9, 2022
Summary: Pull Request resolved: facebookexperimental/rust-shed#26 Pull Request resolved: facebook#104 No need for the checked in generated code anymore Reviewed By: chadaustin Differential Revision: D33840545 fbshipit-source-id: b8c7cac15bd339b922654dbabeb277613f3edc58
ahornby
added a commit
to ahornby/sapling
that referenced
this pull request
Feb 9, 2022
Summary: Pull Request resolved: facebookexperimental/rust-shed#26 Pull Request resolved: facebook#104 No need for the checked in generated code anymore Reviewed By: chadaustin Differential Revision: D33840545 fbshipit-source-id: fede2231fbb1a373039a461b493cbb274379ffc0
ahornby
added a commit
to ahornby/sapling
that referenced
this pull request
Feb 9, 2022
Summary: Pull Request resolved: facebookexperimental/rust-shed#26 Pull Request resolved: facebook#104 No need for the checked in generated code anymore Reviewed By: chadaustin Differential Revision: D33840545 fbshipit-source-id: fbc74e4cfc7eb5d98a9722dc2cad9b3f26ca1823
ahornby
added a commit
to ahornby/sapling
that referenced
this pull request
Feb 9, 2022
Summary: Pull Request resolved: facebookexperimental/rust-shed#26 Pull Request resolved: facebook#104 No need for the checked in generated code anymore Reviewed By: chadaustin Differential Revision: D33840545 fbshipit-source-id: 968d877709689a9156a1f144961a0238ee9e8881
ahornby
added a commit
to ahornby/sapling
that referenced
this pull request
Feb 9, 2022
Summary: Pull Request resolved: facebookexperimental/rust-shed#26 Pull Request resolved: facebook#104 No need for the checked in generated code anymore Reviewed By: chadaustin, mitrandir77 Differential Revision: D33840545 fbshipit-source-id: 38d5e2f310ad4e96cea58d02a4b2fb74a274b7ed
facebook-github-bot
pushed a commit
to facebookincubator/katran
that referenced
this pull request
Feb 9, 2022
Summary: Pull Request resolved: facebookexperimental/rust-shed#26 Pull Request resolved: facebook/sapling#104 No need for the checked in generated code anymore Successful external CI Linux run on Git Hub PR: https://github.com/facebookexperimental/eden/runs/5130405984?check_suite_focus=true Mac PR run fails with a SSL cert issue, will look separately Reviewed By: chadaustin, mitrandir77 Differential Revision: D33840545 fbshipit-source-id: eafc2a0e2191d438fd828adeebc2e318d319025f
facebook-github-bot
pushed a commit
to facebook/mvfst
that referenced
this pull request
Feb 9, 2022
Summary: Pull Request resolved: facebookexperimental/rust-shed#26 Pull Request resolved: facebook/sapling#104 No need for the checked in generated code anymore Successful external CI Linux run on Git Hub PR: https://github.com/facebookexperimental/eden/runs/5130405984?check_suite_focus=true Mac PR run fails with a SSL cert issue, will look separately Reviewed By: chadaustin, mitrandir77 Differential Revision: D33840545 fbshipit-source-id: eafc2a0e2191d438fd828adeebc2e318d319025f
facebook-github-bot
pushed a commit
that referenced
this pull request
Feb 9, 2022
Summary: Pull Request resolved: #26 Pull Request resolved: facebook/sapling#104 No need for the checked in generated code anymore Successful external CI Linux run on Git Hub PR: https://github.com/facebookexperimental/eden/runs/5130405984?check_suite_focus=true Mac PR run fails with a SSL cert issue, will look separately Reviewed By: chadaustin, mitrandir77 Differential Revision: D33840545 fbshipit-source-id: eafc2a0e2191d438fd828adeebc2e318d319025f
facebook-github-bot
pushed a commit
to facebookincubator/fizz
that referenced
this pull request
Feb 9, 2022
Summary: Pull Request resolved: facebookexperimental/rust-shed#26 Pull Request resolved: facebook/sapling#104 No need for the checked in generated code anymore Successful external CI Linux run on Git Hub PR: https://github.com/facebookexperimental/eden/runs/5130405984?check_suite_focus=true Mac PR run fails with a SSL cert issue, will look separately Reviewed By: chadaustin, mitrandir77 Differential Revision: D33840545 fbshipit-source-id: eafc2a0e2191d438fd828adeebc2e318d319025f
facebook-github-bot
pushed a commit
to facebook/openr
that referenced
this pull request
Feb 9, 2022
Summary: Pull Request resolved: facebookexperimental/rust-shed#26 Pull Request resolved: facebook/sapling#104 No need for the checked in generated code anymore Successful external CI Linux run on Git Hub PR: https://github.com/facebookexperimental/eden/runs/5130405984?check_suite_focus=true Mac PR run fails with a SSL cert issue, will look separately Reviewed By: chadaustin, mitrandir77 Differential Revision: D33840545 fbshipit-source-id: eafc2a0e2191d438fd828adeebc2e318d319025f
facebook-github-bot
pushed a commit
to facebook/wangle
that referenced
this pull request
Feb 9, 2022
Summary: Pull Request resolved: facebookexperimental/rust-shed#26 Pull Request resolved: facebook/sapling#104 No need for the checked in generated code anymore Successful external CI Linux run on Git Hub PR: https://github.com/facebookexperimental/eden/runs/5130405984?check_suite_focus=true Mac PR run fails with a SSL cert issue, will look separately Reviewed By: chadaustin, mitrandir77 Differential Revision: D33840545 fbshipit-source-id: eafc2a0e2191d438fd828adeebc2e318d319025f
facebook-github-bot
pushed a commit
to facebook/sapling
that referenced
this pull request
Feb 9, 2022
Summary: Pull Request resolved: facebookexperimental/rust-shed#26 Pull Request resolved: #104 No need for the checked in generated code anymore Successful external CI Linux run on Git Hub PR: https://github.com/facebookexperimental/eden/runs/5130405984?check_suite_focus=true Mac PR run fails with a SSL cert issue, will look separately Reviewed By: chadaustin, mitrandir77 Differential Revision: D33840545 fbshipit-source-id: eafc2a0e2191d438fd828adeebc2e318d319025f
facebook-github-bot
pushed a commit
to facebook/folly
that referenced
this pull request
Feb 9, 2022
Summary: Pull Request resolved: facebookexperimental/rust-shed#26 Pull Request resolved: facebook/sapling#104 No need for the checked in generated code anymore Successful external CI Linux run on Git Hub PR: https://github.com/facebookexperimental/eden/runs/5130405984?check_suite_focus=true Mac PR run fails with a SSL cert issue, will look separately Reviewed By: chadaustin, mitrandir77 Differential Revision: D33840545 fbshipit-source-id: eafc2a0e2191d438fd828adeebc2e318d319025f
facebook-github-bot
pushed a commit
to facebook/watchman
that referenced
this pull request
Feb 9, 2022
Summary: Pull Request resolved: facebookexperimental/rust-shed#26 Pull Request resolved: facebook/sapling#104 No need for the checked in generated code anymore Successful external CI Linux run on Git Hub PR: https://github.com/facebookexperimental/eden/runs/5130405984?check_suite_focus=true Mac PR run fails with a SSL cert issue, will look separately Reviewed By: chadaustin, mitrandir77 Differential Revision: D33840545 fbshipit-source-id: eafc2a0e2191d438fd828adeebc2e318d319025f
facebook-github-bot
pushed a commit
to facebook/fb303
that referenced
this pull request
Feb 9, 2022
Summary: Pull Request resolved: facebookexperimental/rust-shed#26 Pull Request resolved: facebook/sapling#104 No need for the checked in generated code anymore Successful external CI Linux run on Git Hub PR: https://github.com/facebookexperimental/eden/runs/5130405984?check_suite_focus=true Mac PR run fails with a SSL cert issue, will look separately Reviewed By: chadaustin, mitrandir77 Differential Revision: D33840545 fbshipit-source-id: eafc2a0e2191d438fd828adeebc2e318d319025f
facebook-github-bot
pushed a commit
to facebook/fbthrift
that referenced
this pull request
Feb 9, 2022
Summary: Pull Request resolved: facebookexperimental/rust-shed#26 Pull Request resolved: facebook/sapling#104 No need for the checked in generated code anymore Successful external CI Linux run on Git Hub PR: https://github.com/facebookexperimental/eden/runs/5130405984?check_suite_focus=true Mac PR run fails with a SSL cert issue, will look separately Reviewed By: chadaustin, mitrandir77 Differential Revision: D33840545 fbshipit-source-id: eafc2a0e2191d438fd828adeebc2e318d319025f
facebook-github-bot
pushed a commit
to facebookincubator/reindeer
that referenced
this pull request
Feb 9, 2022
Summary: Pull Request resolved: facebookexperimental/rust-shed#26 Pull Request resolved: facebook/sapling#104 No need for the checked in generated code anymore Successful external CI Linux run on Git Hub PR: https://github.com/facebookexperimental/eden/runs/5130405984?check_suite_focus=true Mac PR run fails with a SSL cert issue, will look separately Reviewed By: chadaustin, mitrandir77 Differential Revision: D33840545 fbshipit-source-id: eafc2a0e2191d438fd828adeebc2e318d319025f
facebook-github-bot
pushed a commit
to facebook/proxygen
that referenced
this pull request
Feb 9, 2022
Summary: Pull Request resolved: facebookexperimental/rust-shed#26 Pull Request resolved: facebook/sapling#104 No need for the checked in generated code anymore Successful external CI Linux run on Git Hub PR: https://github.com/facebookexperimental/eden/runs/5130405984?check_suite_focus=true Mac PR run fails with a SSL cert issue, will look separately Reviewed By: chadaustin, mitrandir77 Differential Revision: D33840545 fbshipit-source-id: eafc2a0e2191d438fd828adeebc2e318d319025f
facebook-github-bot
pushed a commit
to facebook/fboss
that referenced
this pull request
Feb 9, 2022
Summary: Pull Request resolved: facebookexperimental/rust-shed#26 Pull Request resolved: facebook/sapling#104 No need for the checked in generated code anymore Successful external CI Linux run on Git Hub PR: https://github.com/facebookexperimental/eden/runs/5130405984?check_suite_focus=true Mac PR run fails with a SSL cert issue, will look separately Reviewed By: chadaustin, mitrandir77 Differential Revision: D33840545 fbshipit-source-id: eafc2a0e2191d438fd828adeebc2e318d319025f
facebook-github-bot
pushed a commit
to facebookarchive/bistro
that referenced
this pull request
Feb 9, 2022
Summary: Pull Request resolved: facebookexperimental/rust-shed#26 Pull Request resolved: facebook/sapling#104 No need for the checked in generated code anymore Successful external CI Linux run on Git Hub PR: https://github.com/facebookexperimental/eden/runs/5130405984?check_suite_focus=true Mac PR run fails with a SSL cert issue, will look separately Reviewed By: chadaustin, mitrandir77 Differential Revision: D33840545 fbshipit-source-id: eafc2a0e2191d438fd828adeebc2e318d319025f
facebook-github-bot
pushed a commit
to facebookarchive/fbzmq
that referenced
this pull request
Feb 9, 2022
Summary: Pull Request resolved: facebookexperimental/rust-shed#26 Pull Request resolved: facebook/sapling#104 No need for the checked in generated code anymore Successful external CI Linux run on Git Hub PR: https://github.com/facebookexperimental/eden/runs/5130405984?check_suite_focus=true Mac PR run fails with a SSL cert issue, will look separately Reviewed By: chadaustin, mitrandir77 Differential Revision: D33840545 fbshipit-source-id: eafc2a0e2191d438fd828adeebc2e318d319025f
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary:
Pull Request resolved: facebook/sapling#104
No need for the checked in generated code anymore
Reviewed By: chadaustin
Differential Revision: D33840545