Ignore children with clashing keys #1364
Merged
+29
−20
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
cc @cpojer |
|
niiiice |
| 'flattenChildren(...): Encountered two children with the same key, `%s`. ' + | ||
| 'Children keys must be unique.', | ||
| 'Children keys should be unique; all children after the first with a ' + | ||
| 'given key will be ignored.', |
There was a problem hiding this comment.
Perhaps a bit anal; to me it's not super obvious if it refers to all children, after the given key or or all subsequent children with the given key. Could perhaps benefit from a rewording, "Child keys must be unique; only the first child for each conflicting key is rendered, the rest are ignored.", must to emphasize that you should not rely on it as a feature (which seems like a bad thing)... or something along those lines perhaps?
PS. Children keys is not gramatically correct I think? Child keys sounds better to me, but I'm not 100% sure.
There was a problem hiding this comment.
Good points, fixed.
|
Like |
zpao
added a commit
that referenced
this pull request
Apr 9, 2014
Ignore children with clashing keys
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #566.