Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Flatten children to array instead of to object #4405

Closed
jimfb opened this issue Jul 16, 2015 · 0 comments
Closed

Flatten children to array instead of to object #4405

jimfb opened this issue Jul 16, 2015 · 0 comments

Comments

@jimfb
Copy link
Contributor

jimfb commented Jul 16, 2015

Flattening children to an array is 20 times faster than flattening to an object. For long list of elements, this shows up on the initial render flame graphs as pretty hot.
@jimfb jimfb mentioned this issue Jul 16, 2015
Merged
jimfb added a commit to jimfb/react that referenced this issue Jul 18, 2015
@jimfb
Removed flattened children object for initial render. Fixes facebook#…
fe99e59 
…4405
jimfb added a commit that referenced this issue Jul 18, 2015
@jimfb
Merge pull request #4408 from jimfb/remove-children-map
c73f952 
Removed flattened children object.  Fixes #4405
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@jimfb