Add support for Buck oncall annotations #35562
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
facebook-github-bot
added
CLA Signed
cortinico
reviewed
Dec 5, 2022
tools/build_defs/preload.bzl
Outdated
| @@ -0,0 +1,4 @@ | |||
| # These are symbols that are available in newer versions of Buck, but not the open source one. | |||
|
|
|||
| def oncall(_team): | |||
There was a problem hiding this comment.
Q: Shouldn't we use tools/build_defs/oss/build_defs.bzl as we're doing for other similar functions?
There was a problem hiding this comment.
Agreed that oss makes more sense - have put it as oss/preload.bzl instead
|
@cortinico has imported this pull request. If you are a Meta employee, you can view this diff on Phabricator. |
robhogan
approved these changes
Dec 5, 2022
|
This pull request was successfully merged by @ndmitchell in bdb2fd6. When will my fix make it into a release? | Upcoming Releases |
OlimpiaZurek
pushed a commit
to OlimpiaZurek/react-native
that referenced
this pull request
May 22, 2023
Summary: Newer versions of Buck (not released open source) support an `oncall` annotation to denote who owns a particular BUCK file. These annotations are useful to support so that if BUCK files are updated with such annotations they don't break. ## Changelog [Internal] [Changed] - support oncall annotation in BUCK files Pull Request resolved: facebook#35562 Test Plan: The `test_buck` CI job validates that the file can be evaluated by open-source Buck. I ran this on a CircleCI fork, and it passed. Reviewed By: motiz88 Differential Revision: D41731925 Pulled By: cortinico fbshipit-source-id: 7d0ae164c3e6289d4aa76892658d46bbe4faf99c
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Newer versions of Buck (not released open source) support an
oncallannotation to denote who owns a particular BUCK file. These annotations are useful to support so that if BUCK files are updated with such annotations they don't break.Changelog
[Internal] [Changed] - support oncall annotation in BUCK files
Test Plan
The
test_buckCI job validates that the file can be evaluated by open-source Buck. I ran this on a CircleCI fork, and it passed.