Skip to content

Commit bdb2fd6

Browse files
ndmitchellfacebook-github-bot
authored andcommitted
Add support for Buck oncall annotations (#35562)
Summary: Newer versions of Buck (not released open source) support an `oncall` annotation to denote who owns a particular BUCK file. These annotations are useful to support so that if BUCK files are updated with such annotations they don't break. ## Changelog [Internal] [Changed] - support oncall annotation in BUCK files Pull Request resolved: #35562 Test Plan: The `test_buck` CI job validates that the file can be evaluated by open-source Buck. I ran this on a CircleCI fork, and it passed. Reviewed By: motiz88 Differential Revision: D41731925 Pulled By: cortinico fbshipit-source-id: 7d0ae164c3e6289d4aa76892658d46bbe4faf99c
1 parent 032bed4 commit bdb2fd6

File tree

3 files changed

+9
-0
lines changed

3 files changed

+9
-0
lines changed

.buckconfig

+3
Original file line numberDiff line numberDiff line change
@@ -15,3 +15,6 @@
1515

1616
[alias]
1717
rntester = //packages/rn-tester/android/app:app
18+
19+
[buildfile]
20+
includes = //tools/build_defs/oss/preload.bzl

ReactAndroid/src/main/java/com/facebook/react/BUCK

+2
Original file line numberDiff line numberDiff line change
@@ -1,5 +1,7 @@
11
load("//tools/build_defs/oss:rn_defs.bzl", "react_native_dep", "react_native_target", "rn_android_library")
22

3+
oncall("react_native")
4+
35
rn_android_library(
46
name = "react",
57
srcs = glob(["*.java"]),

tools/build_defs/oss/preload.bzl

+4
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,4 @@
1+
# These are symbols that are available in newer versions of Buck, but not the open source one.
2+
3+
def oncall(_team):
4+
pass

0 commit comments

Comments
 (0)