Skip to content

Commit 032bed4

Browse files
dcangulofacebook-github-bot
authored andcommitted
remove hermes note (#35555)
Summary: This note was added when upgrading from 0.69x to 0.70.x when `hermes_enabled` is explicitly set to `true`. <img width="669" alt="Screenshot 2022-12-05 at 11 26 15" src="https://user-images.githubusercontent.com/36528176/205543104-b4a72c1c-57c0-422b-881e-8a0cb9d5c2a1.png"> But on 0.71, we are now using `get_default_flags` again which makes the note obsolete. ## Changelog [Internal] [Removed] - removed hermes note Pull Request resolved: #35555 Test Plan: N/A Reviewed By: dmytrorykun Differential Revision: D41731004 Pulled By: cortinico fbshipit-source-id: d5f377062bf94fa73bc6e73d1f108e37ad68c715
1 parent d4a9bdc commit 032bed4

File tree

1 file changed

+0
-2
lines changed

1 file changed

+0
-2
lines changed

template/ios/Podfile

-2
Original file line numberDiff line numberDiff line change
@@ -21,8 +21,6 @@ target 'HelloWorld' do
2121
use_react_native!(
2222
:path => config[:reactNativePath],
2323
# Hermes is now enabled by default. Disable by setting this flag to false.
24-
# Upcoming versions of React Native may rely on get_default_flags(), but
25-
# we make it explicit here to aid in the React Native upgrade process.
2624
:hermes_enabled => flags[:hermes_enabled],
2725
:fabric_enabled => flags[:fabric_enabled],
2826
# Enables Flipper.

0 commit comments

Comments
 (0)