Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Disable reload-and-record action for React Native entrypoint #152

Merged
merged 1 commit into from
Feb 10, 2025

Conversation

hoxyq
Copy link

@hoxyq hoxyq commented Feb 7, 2025

Summary

I've made a typo in #150: this action should only be disabled for React Native entrypoints. We will be adding an opposite experiment to REACT_NATIVE_SPECIFIC_UI and using it to gate this action.

This is not critical, but this action was still alive and was listening for Cmd + Shift + E combination.

Test plan

  • Pressing Cmd + Shift + E does nothing, validates that action is not registered

  • Ran tests locally, all green

  • This change maintains backwards compatibility with previous Local Storage data (if modifying settings, experiments, or other persisted client state).

Upstreaming plan

  • This commit should be sent as a patch to the upstream devtools-frontend repo. I've reviewed the contribution guide.
  • This commit is React Native-specific and cannot be upstreamed.

@hoxyq hoxyq merged commit 3adf51a into main Feb 10, 2025
2 of 3 checks passed
@hoxyq hoxyq deleted the experiment-typo-fix branch February 10, 2025 08:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants