fix: Disable reload-and-record action for React Native entrypoint #152
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
I've made a typo in #150: this action should only be disabled for React Native entrypoints. We will be adding an opposite experiment to
REACT_NATIVE_SPECIFIC_UI
and using it to gate this action.This is not critical, but this action was still alive and was listening for
Cmd + Shift + E
combination.Test plan
Pressing
Cmd + Shift + E
does nothing, validates that action is not registeredRan tests locally, all green
This change maintains backwards compatibility with previous Local Storage data (if modifying settings, experiments, or other persisted client state).
Upstreaming plan
devtools-frontend
repo. I've reviewed the contribution guide.