Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Performance: hide more unsupported features #150

Merged
merged 1 commit into from
Feb 7, 2025

Conversation

hoxyq
Copy link

@hoxyq hoxyq commented Feb 6, 2025

Summary

Enhances the work done in #138. We are gating under RN entrypoint experiment things that we don't support / can't support yet for Performance panel.

See the full list of changes and explanation in this document, we will keep track of them. I will also add Alex's changes to it.

Because we started to use this RN experiment in multiple new places, I had to update some tests to initialize it correctly. Before the changes in this PR, these tests did not use any experiments, now we have to explicitly register them before running test, otherwise Chrome's experiment system will throw an error when we will try to access unregistered experiment.

Test plan

Screenshot 2025-02-06 at 19 18 24

  • This change maintains backwards compatibility with previous Local Storage data (if modifying settings, experiments, or other persisted client state).

Upstreaming plan

  • This commit should be sent as a patch to the upstream devtools-frontend repo. I've reviewed the contribution guide.
  • This commit is React Native-specific and cannot be upstreamed.

@hoxyq hoxyq merged commit 6201613 into main Feb 7, 2025
2 of 3 checks passed
@hoxyq hoxyq deleted the performance/hide-more-unsupported-features branch February 7, 2025 14:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants