Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Detailed crd generation #3298

Merged
merged 10 commits into from
Jul 14, 2021
Merged

Detailed crd generation #3298

merged 10 commits into from
Jul 14, 2021

Conversation

metacosm
Copy link
Collaborator

@metacosm metacosm commented Jul 5, 2021 •
edited
Loading

Description

WIP. The idea is to let CRD generator clients know more about what was
generated and using which information. This should simplify consuming
the CRD generator programmatically.

Fixes #3314.

Type of change

  • Bug fix (non-breaking change which fixes an issue)
  • Feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change
  • Chore (non-breaking change which doesn't affect codebase;
    test, version modification, documentation, etc.)

Checklist

  • Code contributed by me aligns with current project license: Apache 2.0
  • I Added CHANGELOG entry regarding this change
  • I have implemented unit tests to cover my changes
  • I have added/updated the javadocs and other documentation accordingly
  • No new bugs, code smells, etc. in SonarCloud report
  • I tested my code in Kubernetes
  • I tested my code in OpenShift

@centos-ci
Copy link

Can one of the admins verify this patch?

@metacosm metacosm marked this pull request as ready for review July 9, 2021 18:15
@metacosm metacosm self-assigned this Jul 13, 2021
@metacosm metacosm added changelog missing A line to changelog.md regarding the change is not added component/crd-generator Related to the CRD generator labels Jul 13, 2021
@metacosm metacosm added this to the 5.6.0 milestone Jul 13, 2021
@rohanKanojia rohanKanojia requested a review from shawkins July 13, 2021 16:06
@snowdrop-bot snowdrop-bot mentioned this pull request Jul 13, 2021
Closed
11 tasks
metacosm added 10 commits July 13, 2021 19:11
@metacosm metacosm force-pushed the detailed-crd-generation branch from 428a064 to 2e7a40d Compare July 13, 2021 17:14
@sonarqubecloud
Copy link

Kudos, SonarCloud Quality Gate passed!

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 2 Code Smells

93.1% 93.1% Coverage
0.0% 0.0% Duplication

manusa
manusa approved these changes Jul 14, 2021
View reviewed changes
Copy link
Member

@manusa manusa left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thx!

@manusa manusa requested a review from rohanKanojia July 14, 2021 05:32
@manusa manusa merged commit adcce5a into master Jul 14, 2021
@manusa manusa deleted the detailed-crd-generation branch July 14, 2021 07:34
@manusa manusa removed the changelog missing A line to changelog.md regarding the change is not added label Jul 21, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@manusa manusa manusa approved these changes

@rohanKanojia rohanKanojia rohanKanojia approved these changes

@iocanel iocanel Awaiting requested review from iocanel

@shawkins shawkins Awaiting requested review from shawkins

Assignees

@metacosm metacosm

Labels
component/crd-generator Related to the CRD generator
Projects
None yet
Milestone
5.6.0
Development

Successfully merging this pull request may close these issues.

Provide more detailed information about what is being generated during CRD generation
4 participants
@metacosm @centos-ci @manusa @rohanKanojia