This repository has been archived by the owner on Jun 19, 2024. It is now read-only.
Fix #1444: Option to Disable Liveness/readiness checks #1569
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rohanKanojia
force-pushed
the
pr/issue1444
branch
from
e1a795e to
a1a4fdf
Compare
devang-gaur
suggested changes
Mar 12, 2019
There was a problem hiding this comment.
Minor nitpicks, otherwise LGTM. @lordofthejars let us know what you think of my comments. I'll approve if you deem it correct.
| @@ -225,6 +225,9 @@ | |||
| @Parameter(property = "fabric8.namespace") | |||
| private String namespace; | |||
|
|
|||
| @Parameter(property = "fabric8.skipHealthChecks", defaultValue = "false") | |||
| private Boolean skipHealthChecks; | |||
There was a problem hiding this comment.
fabric8.disableProbes might be a better name since Its Health probe and liveness probe.
if not, atleast remove s , just fabric8.skipHealthCheck :)
| | If the value is set to `true` then no readiness/liveness checks would be added to any containers. | ||
| | `false` | ||
|
|
||
| | *fabric8.openshift.deployTimeoutSeconds* |
There was a problem hiding this comment.
not much of an issue, but maybe a seperate commit should be there for the 'extra' documentation, not relating to PR or commit description.
+ Added an option fabric8.disableHealthChecks to disable readiness/liveness checks + Added path option in SpringBootHealthCheckEnricher to overwrite path for liveness/readiness
rohanKanojia
force-pushed
the
pr/issue1444
branch
from
a1a4fdf to
30cc140
Compare
lordofthejars
approved these changes
Mar 13, 2019
|
@dev-gaur : I've addressed your comments, going to merge now. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix #1444
fabric8.disableHealthChecksto disable readiness/liveness checks