Skip to content
This repository has been archived by the owner on Jun 19, 2024. It is now read-only.

Option to Disable Liveness/readiness checks #1444

Closed
Na3blis opened this issue Dec 3, 2018 · 6 comments
Closed

Option to Disable Liveness/readiness checks #1444

Na3blis opened this issue Dec 3, 2018 · 6 comments
Assignees
Labels
cat/feature Feature request

Comments

@Na3blis
Copy link

Na3blis commented Dec 3, 2018

Description

I need to be able to disable the actuator enricher, or be able to overwrite the path that it checks for both liveness and readiness

Info

  • f-m-p version : 3.5.41
  • Maven version (mvn -v) : 3.6.0
  • Kubernetes / OpenShift setup and version :
    minikube v0.30.0
  • If it's a feature request, what is your use case :
    My project uses custom JWTs to secure endpoints. K8 is not able to access the standard actuator endpoints, and so we have created custom endpoints for liveness/readiness checks that are open for k8. However, since we have actuator on the classpath, f-m-p adds liveness and readiness checks that will always fail because k8 gets a 403 error.
@stale
Copy link

stale bot commented Mar 3, 2019

This issue has been automatically marked as stale because it has not had any activity since 90 days. It will be closed if no further activity occurs within 7 days. Thank you for your contributions!

@stale stale bot added the status/stale Issue/PR considered to be stale label Mar 3, 2019
@stale stale bot closed this as completed Mar 10, 2019
@rohanKanojia rohanKanojia reopened this Mar 10, 2019
@stale stale bot removed the status/stale Issue/PR considered to be stale label Mar 10, 2019
@rohanKanojia rohanKanojia added the cat/feature Feature request label Mar 12, 2019
@rohanKanojia rohanKanojia self-assigned this Mar 12, 2019
rohanKanojia added a commit to rohanKanojia/fabric8-maven-plugin that referenced this issue Mar 12, 2019
+ Added an option fabric8.disableHealthChecks to disable readiness/liveness checks
+ Added path option in SpringBootHealthCheckEnricher to overwrite path for liveness/readiness
rohanKanojia added a commit to rohanKanojia/fabric8-maven-plugin that referenced this issue Mar 12, 2019
+ Added an option fabric8.disableHealthChecks to disable readiness/liveness checks
+ Added path option in SpringBootHealthCheckEnricher to overwrite path for liveness/readiness
rohanKanojia added a commit to rohanKanojia/fabric8-maven-plugin that referenced this issue Mar 13, 2019
+ Added an option fabric8.disableHealthChecks to disable readiness/liveness checks
+ Added path option in SpringBootHealthCheckEnricher to overwrite path for liveness/readiness
rohanKanojia added a commit that referenced this issue Mar 13, 2019
+ Added an option fabric8.disableHealthChecks to disable readiness/liveness checks
+ Added path option in SpringBootHealthCheckEnricher to overwrite path for liveness/readiness
@rohanKanojia
Copy link
Member

@Na3blis : Could you please try 4.0.0 out and see if it is working as per your use case?

@Na3blis
Copy link
Author

Na3blis commented Apr 10, 2019

That's what I was looking for, thanks!

@rohanKanojia
Copy link
Member

@Na3blis : Did it work according to your use case?

@Na3blis
Copy link
Author

Na3blis commented Apr 10, 2019

Yep, that resolved the issues. Both options actually were good, and resolved my issues when testing

@rohanKanojia
Copy link
Member

good to hear ;-)

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
cat/feature Feature request
Projects
None yet
Development

No branches or pull requests

2 participants