This repository has been archived by the owner on Jun 19, 2024. It is now read-only.
Java11 #1437
Merged
Java11 #1437
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
With this PR, "mvn clean install" are successful both on JDK8 and JDK11. |
Codecov Report
@@ Coverage Diff @@
## master #1437 +/- ##
============================================
+ Coverage 34.87% 34.87% +<.01%
Complexity 1046 1046
============================================
Files 171 171
Lines 9431 9433 +2
Branches 1611 1612 +1
============================================
+ Hits 3289 3290 +1
Misses 5783 5783
- Partials 359 360 +1 |
rohanKanojia
approved these changes
Nov 16, 2018
oscerd
approved these changes
Nov 16, 2018
| @@ -66,6 +66,10 @@ public String getLabel() { | |||
| * Returns true if the given maven properties indicate running in OpenShift platform mode | |||
| */ | |||
| public static boolean isOpenShiftMode(Properties properties) { | |||
| return Objects.equal(openshift.toString(), properties.getProperty(FABRIC8_EFFECTIVE_PLATFORM_MODE, "")); | |||
| if (properties == null) { | |||
There was a problem hiding this comment.
Maybe I will use a ternary in this case just for make code clean, but just my opinion of course.
| @@ -71,6 +69,9 @@ public void javaOptions() throws IOException, MojoExecutionException { | |||
| assertEquals(1, configs.size()); | |||
| Map<String, String> env = configs.get(0).getBuildConfiguration().getEnv(); | |||
| assertNull(env.get("JAVA_OPTIONS")); | |||
| } catch (Exception ex) { | |||
| ex.printStackTrace(); | |||
There was a problem hiding this comment.
can you make the test make error by rethrowing the exception?
Also if there is an exception the test will fail automatically and print the stack trace.
There was a problem hiding this comment.
Ah, that just for my debug and surely should be removed.
Another commit is coming soon...
lordofthejars
approved these changes
Nov 16, 2018
|
Thank you very much for the contribution. |
Closed
lordofthejars
pushed a commit
to lordofthejars/fabric8-maven-plugin
that referenced
this pull request
Jan 17, 2019
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.