Skip to content
This repository has been archived by the owner on Jun 19, 2024. It is now read-only.

Support for zero-config jdk 11 Docker base image #1647

Closed
grantsheer-eoh opened this issue Jun 3, 2019 · 3 comments · Fixed by #1652
Closed

Support for zero-config jdk 11 Docker base image #1647

grantsheer-eoh opened this issue Jun 3, 2019 · 3 comments · Fixed by #1652
Assignees

Comments

@grantsheer-eoh
Copy link

Description

Looking to have the FMP support a Zero config JDK 11 Docker base image as it does for JDK 8. So ideally it should use the JDK 8/11 docker base image depending on whether the the compiler version of the Maven build is Java 8/11.

Info

We ideally would want a zero-config (or close to it) option for creating a Spring Boot app using a JDK 11 Docker base image – as there is for JDK 8. I see there is a JDK 11 docker base image available as of April 2019:
https://hub.docker.com/r/fabric8/java-centos-openjdk11-jdk
https://hub.docker.com/r/fabric8/java-centos-openjdk11-jre

Also, I see there is a bug logged for JDK 11 on the maven plugin:
#1472
#1437
https://github.com/fabric8io/fabric8-maven-plugin/projects/5

  • f-m-p version : 3.5.41
  • Maven version (mvn -v) : 3.5.3

  • If it's a feature request, what is your use case : Deploy my JDK 11 Spring Boot App in Docker
@rohanKanojia
Copy link
Member

@dev-gaur is working on jdk11 Support.

@grantsheer-eoh
Copy link
Author

Thanks.

@dev-gaur, when are you aiming to have that ready for?

Also, which version is it planned for?

@devang-gaur devang-gaur self-assigned this Jun 6, 2019
@devang-gaur
Copy link
Contributor

@grantsheer-eoh I'm working on this now..

For the time being..

    <profile>
      <id>java11-image</id>
      <activation>
        <jdk>[11,)</jdk>
      </activation>
      <properties>
        <fabric8.generator.fromMode>docker</fabric8.generator.fromMode>
        <fabric8.generator.from>fabric8/java-centos-openjdk11-jre</fabric8.generator.from>
      </properties>
    </profile>

Add this profile to your project pom.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants