EZP-28861: Allow template and controller dispatching based on matcher configuration for Content Create #217

webhdx · 2018-02-22T13:19:58Z

JIRA: https://jira.ez.no/browse/EZP-28861
Requires: #215
Requires: ezsystems/ezplatform-admin-ui#376 (to test in AdminUI)

TODO

rebase to master once EZP-28849: Allow repository forms to use View Manager for handling draft edit controller and template dispatching #215 gets merged

alongosz

Mostly nitpicking 🙃

alongosz · 2018-02-28T11:31:31Z

bundle/Controller/ContentEditController.php

     *
-     * @throws \eZ\Publish\Core\Base\Exceptions\InvalidArgumentType
-     * @throws \eZ\Publish\API\Repository\Exceptions\UnauthorizedException
-     * @throws \eZ\Publish\API\Repository\Exceptions\NotFoundException


This method can still throw NotFoundException, so you shouldn't skip it.

alongosz · 2018-02-28T11:33:22Z

bundle/Controller/ContentEditController.php

     * @param \Symfony\Component\HttpFoundation\Request $request
+     * @param ContentCreateView $view


Please keep consistency when hinting types, either FQCN or not. :) I'd suggest FQCN due to existing code, but it's up to you.

alongosz · 2018-02-28T12:14:34Z

bundle/Controller/ContentEditController.php

+        $contentId,
+        $versionNo = null,
+        $language = null,
+        $locationId = null


Missing PhpDoc for this argument.

alongosz · 2018-02-28T12:55:31Z

bundle/DependencyInjection/Compiler/ViewBuilderRegistryPass.php

+use Symfony\Component\DependencyInjection\ContainerBuilder;
+
+/**
+ * Compiler pass to register Limitation value mappers.


That seems like copy-paste error ;)

@webhdx this hasn't been addressed.

alongosz · 2018-02-28T12:57:44Z

bundle/DependencyInjection/Configuration/Parser/ContentEdit.php

@@ -22,7 +22,7 @@ public function addSemanticConfig(NodeBuilder $nodeBuilder)
    {
        $nodeBuilder
            ->arrayNode('content_edit')
-                ->info('Content edit configuration')
+                ->info('Content edit configuration. This key was deprecated in 2.1 and will be removed in 3.0. Please use siteaccess aware content_create_view key.')


Please use ->deprecated() call for that (see other usages for deprecation message format).

alongosz · 2018-02-28T13:31:27Z

lib/Content/View/Builder/ContentEditViewBuilder.php

+     */
+    private function loadLocation($locationId)
+    {
+        return $this->repository->getLocationService()->loadLocation($locationId);


Based on other ViewBuilder classes, this makes me think it belongs to common base or trait.

alongosz · 2018-02-28T13:32:11Z

lib/Content/View/ContentCreateView.php

+    }
+
+    /**
+     * @return $contentType


return type-hint typo

alongosz · 2018-02-28T13:32:58Z

lib/Content/View/ContentCreateView.php

+    }
+
+    /**
+     * @return Location


Location|null or is ?Location also correct for PhpDoc? (don't know).

alongosz · 2018-02-28T13:36:49Z

lib/Content/View/Provider/ContentCreateView/Configured.php

+use Symfony\Component\HttpKernel\Controller\ControllerReference;
+
+/**
+ * Base for View Providers.


Copy-paste typo.

alongosz · 2018-02-28T13:38:04Z

lib/Content/View/Provider/ContentEditView/Configured.php

+use Symfony\Component\HttpKernel\Controller\ControllerReference;
+
+/**
+ * Base for View Providers.


Copy-paste typo.

webhdx · 2018-03-08T14:19:01Z

@mikadamczyk @Nattfarinn @ViniTou @alongosz Code review needed. Please review only 08de72e commit as it's based on #215 for the time being.

alongosz

This might need a rebase, added also review to #215
One thing left here:

alongosz · 2018-03-09T08:05:55Z

lib/Content/View/Builder/ContentCreateViewBuilder.php

+     *
+     * @throws \eZ\Publish\API\Repository\Exceptions\UnauthorizedException
+     * @throws \eZ\Publish\API\Repository\Exceptions\NotFoundException
+     * @throws \eZ\Publish\Core\Base\Exceptions\InvalidArgumentException


@webhdx please type-hint API.

… configuration for Content Create

webhdx added the Work in progress label Feb 22, 2018

webhdx self-assigned this Feb 22, 2018

webhdx changed the title ~~[WIP] EZP-28849: Allow repository forms to use View Manager for handling draft edit controller and template dispatching~~ EZP-28849: Allow repository forms to use View Manager for handling draft edit controller and template dispatching Feb 28, 2018

webhdx requested review from lserwatka, mikadamczyk, Nattfarinn and ViniTou February 28, 2018 08:16

alongosz requested changes Feb 28, 2018

View reviewed changes

webhdx removed the Work in progress label Mar 5, 2018

webhdx changed the title ~~EZP-28849: Allow repository forms to use View Manager for handling draft edit controller and template dispatching~~ EZP-28861: Allow template and controller dispatching based on matcher configuration for Content Create Mar 5, 2018

webhdx mentioned this pull request Mar 7, 2018

EZP-28314: As a v2 Editor, I want to select a SiteAccess in the Preview mode ezsystems/ezplatform-admin-ui#371

Merged

2 tasks

webhdx force-pushed the EZP-28861_content_view_config branch 2 times, most recently from 816f060 to 6de1316 Compare March 8, 2018 13:59

ezsystems deleted a comment from ezrobot Mar 8, 2018

webhdx force-pushed the EZP-28861_content_view_config branch 2 times, most recently from ca74e45 to 08de72e Compare March 8, 2018 14:16

alongosz requested changes Mar 9, 2018

View reviewed changes

webhdx force-pushed the EZP-28861_content_view_config branch 2 times, most recently from 2786762 to c19d7d7 Compare March 12, 2018 12:53

EZP-28861: Allow template and controller dispatching based on matcher…

66cd116

… configuration for Content Create

webhdx force-pushed the EZP-28861_content_view_config branch from c19d7d7 to 66cd116 Compare March 12, 2018 12:54

lserwatka merged commit 801d9ef into ezsystems:master Mar 12, 2018

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

EZP-28861: Allow template and controller dispatching based on matcher configuration for Content Create #217

EZP-28861: Allow template and controller dispatching based on matcher configuration for Content Create #217

webhdx commented Feb 22, 2018 •

edited

Loading

alongosz left a comment

alongosz Feb 28, 2018

alongosz Feb 28, 2018

alongosz Feb 28, 2018

alongosz Feb 28, 2018

alongosz Mar 9, 2018

alongosz Feb 28, 2018

alongosz Feb 28, 2018

alongosz Feb 28, 2018

alongosz Feb 28, 2018

alongosz Feb 28, 2018

alongosz Feb 28, 2018

webhdx commented Mar 8, 2018

alongosz left a comment

alongosz Mar 9, 2018

		* @param \Symfony\Component\HttpFoundation\Request $request
		* @param ContentCreateView $view

EZP-28861: Allow template and controller dispatching based on matcher configuration for Content Create #217

EZP-28861: Allow template and controller dispatching based on matcher configuration for Content Create #217

Conversation

webhdx commented Feb 22, 2018 • edited Loading

TODO

alongosz left a comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

webhdx commented Mar 8, 2018

alongosz left a comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

webhdx commented Feb 22, 2018 •

edited

Loading