EZP-28314: As a v2 Editor, I want to select a SiteAccess in the Preview mode #371
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
webhdx
requested review from
lserwatka,
mikadamczyk,
Nattfarinn,
micszo and
ViniTou
webhdx
force-pushed
the
EZP-28314_siteaccess_preview
branch
2 times, most recently
from
2ba5236 to
f4700bb
Compare
webhdx
force-pushed
the
EZP-28314_siteaccess_preview
branch
from
f4700bb to
4ac2d92
Compare
Nattfarinn
suggested changes
Mar 12, 2018
| use eZ\Publish\Core\Base\Exceptions\BadStateException; | ||
| use eZ\Publish\Core\MVC\ConfigResolverInterface; | ||
|
|
||
| class NonAdminSiteaccessResolver |
There was a problem hiding this comment.
We have NonAdminSiteaccessResolver and SiteaccessResolver, both share few method signatures. I guess it would be best if they implemented same interface.
webhdx
force-pushed
the
EZP-28314_siteaccess_preview
branch
from
4ac2d92 to
8881484
Compare
webhdx
force-pushed
the
EZP-28314_siteaccess_preview
branch
from
8881484 to
60ce754
Compare
|
@Nattfarinn I've added |
lserwatka
approved these changes
Mar 12, 2018
Nattfarinn
approved these changes
Mar 12, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Since this PR is relying on a lot of other PR my advice is to wait till we merge other things first.
Checklist:
$ composer fix-cs)