EZP-31275: Added tests for SearchService findLocations method covering IsEmpty Criterion #2915
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mateuszbieniek
requested review from
adamwojs,
andrerom,
alongosz and
konradoboza
konradoboza
requested changes
Jan 10, 2020
(╯°□°）╯︵ ┻━┻ |
adamwojs
approved these changes
Jan 10, 2020
Co-Authored-By: Adam Wójs <[email protected]>
konradoboza
approved these changes
Jan 10, 2020
andrerom
approved these changes
Jan 13, 2020
|
You can merge it up. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds test so IsEmpty Critertion is checked for
SearchService::findLocationsas well.Also (a little out-of-scope) fixes one test for
findContentwhich was never executed :PFollowup for: ezsystems/ezplatform-solr-search-engine#164