Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

EZP-31275: Fixed wrong tag for ContentDocumentEmptyFields #164

Merged
merged 1 commit into from
Jan 14, 2020

Conversation

mateuszbieniek
Copy link
Contributor

@mateuszbieniek mateuszbieniek commented Jan 9, 2020

The empty field was indexed only for Contents (not Locations), therefore it was impossible to use IsEmpty Criterion when searching for locations.

This PR changes tag for EzSystems\EzPlatformSolrSearchEngine\FieldMapper\ContentTranslationFieldMapper\ContentDocumentEmptyFields to ezpublish.search.solr.field_mapper.block_translation so empty fields will be indexed also for Locations.

After applying the fix php bin/console ezplatform:reindex has to be executed to create indexes containing empty fields for locations.

More in JIRA ticket: https://jira.ez.no/browse/EZP-31275

@adamwojs adamwojs changed the title Fixed wrong tag for ContentDocumentEmptyFields EZP-31275: Fixed wrong tag for ContentDocumentEmptyFields Jan 9, 2020
Copy link
Member

@adamwojs adamwojs left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@mateuszbieniek +1 but we need integration test 😉

@mateuszbieniek
Copy link
Contributor Author

@adamwojs here you go: ezsystems/ezpublish-kernel#2915 :)

@micszo micszo self-assigned this Jan 14, 2020
Copy link
Member

@micszo micszo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

QA Approved on eZ Platform EE v2.5.8 with diff.

@micszo micszo removed their assignment Jan 14, 2020
@lserwatka lserwatka merged commit 369b3a1 into ezsystems:1.7 Jan 14, 2020
@lserwatka
Copy link
Member

You can merge it up.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Development

Successfully merging this pull request may close these issues.

8 participants