Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

EZP-29531: Do not render layout when rendering selection and relation items #2205

Merged
merged 1 commit into from
Oct 3, 2018
Merged

EZP-29531: Do not render layout when rendering selection and relation items #2205

merged 1 commit into from
Oct 3, 2018

Conversation

emodric
Copy link
Contributor

@emodric emodric commented Dec 20, 2017 •
edited
Loading

https://jira.ez.no/browse/EZP-29531

Without this fix, rendering relation and selection items in eZ Platform Admin UI v2 looks like this:

screenshot from 2017-12-20 18-00-31

With the fix, it looks like this:

screenshot from 2017-12-20 18-00-51

@ezrobot

This comment has been minimized.

Sign in to view
@emodric
Copy link
Contributor Author

emodric commented Dec 21, 2017

Ping :)

It would help a lot if this could land into 7.0 final :)

@andrerom
Copy link
Contributor

pong @lserwatka / @Nattfarinn

@lserwatka
Copy link
Member

I'm fine with this. I don't see any reason why layout should be used here.

@webhdx
Copy link
Contributor

webhdx commented Dec 21, 2017 •
edited
Loading

Hello @emodric,
We have pending PR in AdminUI which fixes this: ezsystems/ezplatform-admin-ui#262

@emodric
Copy link
Contributor Author

emodric commented Dec 21, 2017

@webhdx Great! But since these are generic templates used basically everywhere, it should be fixed here too.

@lserwatka
Copy link
Member

lserwatka commented Dec 21, 2017 •
edited
Loading

@emodric But you pointed out AdminUI, not a frontend template. What other uses do you have? AdminUI was resolved in the given PR.

@emodric
Copy link
Contributor Author

emodric commented Dec 21, 2017

I pointed out admin ui specifically, because we have frontensld templates overriden with this fix. But the issue stands.

@lserwatka
Copy link
Member

Right not, those templates are a bit outdated to be honest. Fixing one, does not solve all problems we have here. I would rather fix all of them as part of bigger story for 7.1 kernel.

@emodric
Copy link
Contributor Author

emodric commented Dec 21, 2017

As you wish. My point is that we as most of our client override them to fix this issue. Hence the PR

@lserwatka
Copy link
Member

lserwatka commented Dec 21, 2017 •
edited
Loading

The thing is, that we are very late in the process now. We are tagging final tomorrow. We can prioritise story for basic field types core templates for next release and include fix like this.

@emodric
Copy link
Contributor Author

emodric commented Dec 21, 2017

No problem, I understand :)

@lserwatka
Copy link
Member

Closing for now. We will get back to this change as part of bigger for story for core base templates.

@lserwatka lserwatka closed this Dec 21, 2017
@andrerom andrerom reopened this Aug 13, 2018
@andrerom andrerom changed the base branch from 7.0 to 7.2 August 13, 2018 07:46
@andrerom
Copy link
Contributor

andrerom commented Aug 13, 2018 •
edited
Loading

@lserwatka re-opening this, as this template is also used on front for field type rendering (the changes in content_fields.html.twig) making sure they correctly use the layout parameter is good both in terms of use as as well as making sure people don't think noLayout is what is supposed to be used on this side of things. Hence making sure the layout => noLayout parameter conversion works as intended.

@emodric can you rebase on 7.2?

@emodric
Copy link
Contributor Author

emodric commented Aug 13, 2018

@andrerom Done.

@andrerom

This comment has been minimized.

Sign in to view
@emodric

This comment has been minimized.

Sign in to view
@andrerom

This comment has been minimized.

Sign in to view
@emodric emodric changed the title Do not render layout when rendering selection and relation items EZP-29531: Do not render layout when rendering selection and relation items Aug 13, 2018
@emodric

This comment has been minimized.

Sign in to view
@andrerom

This comment has been minimized.

Sign in to view
@emodric

This comment has been minimized.

Sign in to view
@emodric emodric changed the base branch from 7.2 to 6.13 August 13, 2018 13:22
@emodric emodric mentioned this pull request Aug 13, 2018
Closed
alongosz
alongosz approved these changes Aug 13, 2018
View reviewed changes
Copy link
Member

@alongosz alongosz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yeah, let's fix it. But why not for 6.7? ping @andrerom

@andrerom
Copy link
Contributor

This one should be for 6.7 now as the other PR was closed, you fix @emodric ?

@emodric emodric changed the base branch from 6.13 to 6.7 August 13, 2018 13:53
@emodric
Copy link
Contributor Author

emodric commented Aug 13, 2018

6.7 is fine ofcourse :) Rebased.

emodric added a commit to netgen/site-bundle that referenced this pull request Aug 18, 2018
@emodric
Add override for ezobjectrelation_field and ezobjectrelationlist_field
f9fe479 
blocks to disable rendering the entire layout

Part of the declined PR at ezsystems/ezpublish-kernel#2205
@emodric
Copy link
Contributor Author

emodric commented Aug 20, 2018

So, is this going in? :)

@andrerom
Copy link
Contributor

andrerom commented Oct 3, 2018

🤕 Forgot about this one, sorry for the delay, but yes this is going in 👍

@andrerom andrerom merged commit 12d0525 into ezsystems:6.7 Oct 3, 2018
@emodric
Copy link
Contributor Author

emodric commented Oct 3, 2018

@andrerom Better late than never :) Is it going to end up in 7.3 final?

@andrerom
Copy link
Contributor

andrerom commented Oct 3, 2018

Yes :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@andrerom andrerom andrerom approved these changes

@alongosz alongosz alongosz approved these changes

@bdunogier bdunogier Awaiting requested review from bdunogier

@Nattfarinn Nattfarinn Awaiting requested review from Nattfarinn

Assignees
No one assigned
Labels
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
6 participants
@emodric @ezrobot @andrerom @lserwatka @webhdx @alongosz