EZP-28318: Implement FieldType view templates in AdminUI #262
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Richtext issues with image and embedded content: |
|
Type is missing for ezimage (left - app, right - mockup) |
|
Different download buttons for ezfile: |
|
ezimage - in field there is no information about file type |
|
Country: empty space for Country field: |
webhdx
force-pushed
the
fieldtypes-preview-admin
branch
from
aece320 to
8609d3b
Compare
emodric
reviewed
Dec 21, 2017
| </thead> | ||
| {% for contentId in field.value.destinationContentIds %} | ||
| <tr> | ||
| {{ render(controller('ez_content:viewAction', {'contentId': contentId, 'viewType': 'embed', 'noLayout': 1, 'layout': 'preview_ezobjectrelationlist_row'})) }} |
There was a problem hiding this comment.
I think this should be layout: false, rather than noLayout: 1
There was a problem hiding this comment.
Does not matter as the twig used for rendering ezobjectrelationlist isn't extending pagelayout. But I will fix it nonetheless.
| </tr> | ||
| </thead> | ||
| <tr> | ||
| {{ render(controller('ez_content:viewAction', {'contentId': field.value.destinationContentId, 'viewType': 'embed', 'noLayout': 1, 'layout': 'preview_ezobjectrelationlist_row'})) }} |
mateuszdebinski
pushed a commit
that referenced
this pull request
Oct 25, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Checklist:
$ composer fix-cs)