EZP-27290: Remove abstract on DebugTemplate to fix dumping logs in profiler

[emodric]

https://jira.ez.no/browse/EZP-27290

Starting with symfony/symfony@eddecbd and in combination with legacy eZ templates, when an exception happens (even a silenced deprecation notice, which is converted to an exception) while rendering the template, one gets a message Cannot instantiate abstract class eZ\Bundle\EzPublishDebugBundle\Twig\DebugTemplate in the log, which ultimately breaks the profiler.

The issue comes from https://github.com/symfony/symfony/blob/master/src/Symfony/Component/VarDumper/Caster/ExceptionCaster.php#L201-L202, which presumes that every subclass of Twig_Template is instantiable.

Haven't found other way to solve this other than this. The fix is also compatible with Twig 2.0 (for when we enable it again in the repo).

[andrerom]

@lolautruche review ping

[emodric]

It turns out this is not related to eZ Legacy exclusivelly. The error basically occurs with any deprecation message that happens during rendering of a Twig template.

[bdunogier]

would it make sense to fix it upstream ? Trying to instanciate abstracts doesn't sound right.

[emodric]

Well, as far as I know, Twig_Template was never meant to be extended. unserialize call in ExceptionCaster that's causing the issue is there from Symfony 2.8 era, it only now came to light as an issue, due to implementing changes to logger profiler.

[andrerom]

is this feature (us extending it to add inline debug in html) needed anymore btw? doesn't Twig or TwigBundle by now have a similar out of the box feature?

[emodric]

@andrerom I'm not aware of it. Can you provide more details?

[andrerom]

no :)

[emodric]

So, what can we do here?

Going in, or shall we look for other solutions?

[lolautruche]

AFAIK Twig doesn't provide the same thing out of the box.
Yes Twig bundle provides a graph, but no delimiters like we provide (maybe we should propose it).

So I'm +1 to merge this in

[andrerom]

but no delimiters like we provide (maybe we should propose it).

could do that in for instance 3.4 if they would be interested in such a feature. The buffering might be a problem, but maybe not.

[emodric]

@andrerom Need an issue?

[andrerom]

@emodric yes please

[emodric]

@andrerom Done!

[andrerom]

@bdunogier ? (the failure is unrelated, afaik it should be fixed if @emodric rebases)

[emodric]

@andrerom Rebased.

[emodric]

So, going in? :)

[alongosz]

👍

[bdunogier]

In my opinion, this should go into 6.7 (LTS). Any objection ?

[emodric]

@bdunogier I don't see why not, but 6.9 kernel is the first one that supports Symfony 3.x anyway, so maybe no need?

[andrerom]

It was added to 6.7 in f3b9c53