Symfony 3.x compatibility #90
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
andrerom
approved these changes
Apr 14, 2017
|
@andrerom Ready for merge and tag? Together with ezsystems/ezpublish-kernel#1957, everything appears to be working fine. The tag could be |
|
@lolautruche review ping :) |
lolautruche
approved these changes
Apr 19, 2017
| @@ -87,7 +87,7 @@ public function init() | |||
| $this->kernelFactory->setBuildEventsEnabled(false); | |||
|
|
|||
| /** @var $request \Symfony\Component\HttpFoundation\ParameterBag */ | |||
| $request = $this->container->get('request')->request; | |||
| $request = $this->container->get('request_stack')->getCurrentRequest()->request; | |||
There was a problem hiding this comment.
Couldn't the request be injected as an argument?
There was a problem hiding this comment.
Sure can, but then it's a breaking change :)
|
@andrerom @lolautruche Some more commits added for compatibility with Sf 3.x, please review :) |
|
Still +1 |
|
Thanks! 👍 |
|
GitHub stalled for a moment, PR is merged in 3bdb710, but it didn't mark as merged, so closing. |
ezpublishlegacy
pushed a commit
to ezpublishlegacy/LegacyBridge
that referenced
this pull request
May 13, 2017
Symfony 3.x compatibility
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Removes usage of Symfony
*.classparameters for compatibility with Symfony 3.x.Also contains a followup to #88 by @wizhippo, due to ezsystems/ezpublish-kernel#1910
Removes usage of
requestservice.Removes usage of
ContainerAwareabstract class.Replaced deprecated CSRF token provider with token manager
Removed depreacted usage of
$absoluteargument in routerMore fixes probably incoming :)