Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

EZP-29812: As an editor I want to embed a content item within a block element #23

Merged
merged 4 commits into from
Dec 10, 2018

Conversation

alongosz
Copy link
Member

@alongosz alongosz commented Dec 6, 2018

Question Answer
JIRA issue EZP-29812
Required by ezsystems/ezplatform-admin-ui#736
Bug/Improvement no
New feature yes
Target version 1.0 (master) for eZ Platform 2.4
BC breaks no
Tests pass yes
Doc needed yes

This PR adds support for embed-inline View Type.

TODO:

  • Refactor prepending core DIC settings for better readability.
  • Create and configure embed-inline eZ Platform View Type (SA-aware).
  • Implement tests.
  • Fix new code according to Coding Standards ($ composer fix-cs).
  • Ask for Code Review.

@alongosz alongosz force-pushed the ezp-29812-add-embed-inline-view branch from 5b28f0f to b615603 Compare December 7, 2018 11:04
@alongosz alongosz force-pushed the ezp-29812-add-embed-inline-view branch from b615603 to 09a2718 Compare December 7, 2018 11:17
@alongosz alongosz requested a review from webhdx December 7, 2018 11:20
@katarzynazawada katarzynazawada self-assigned this Dec 7, 2018
@lserwatka lserwatka merged commit f14dfcc into ezsystems:master Dec 10, 2018
@alongosz alongosz deleted the ezp-29812-add-embed-inline-view branch December 10, 2018 15:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Development

Successfully merging this pull request may close these issues.

6 participants