-
Notifications
You must be signed in to change notification settings - Fork 56
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
EZP-29812: As an editor, I want to embed a content item within a block element #736
Conversation
src/bundle/Resources/public/js/alloyeditor/src/toolbars/config/ez-embed-inline.js
Outdated
Show resolved
Hide resolved
src/bundle/Resources/public/js/alloyeditor/src/toolbars/config/ez-embed-inline.js
Outdated
Show resolved
Hide resolved
src/bundle/Resources/public/js/alloyeditor/src/widgets/ez-embed-base.js
Outdated
Show resolved
Hide resolved
src/bundle/Resources/public/js/alloyeditor/src/widgets/ez-embed-base.js
Outdated
Show resolved
Hide resolved
src/bundle/Resources/public/js/alloyeditor/src/widgets/ez-embed-base.js
Outdated
Show resolved
Hide resolved
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
1) RichText Editor is not styled properly when changing block styles.
- Embed content.
- Type something.
- Change style (e.g Heading 1)
2) Embed content item is not visible in edit mode.
- Embed content.
- Publish.
- Edit.
3) Remove issue
- Type some text.
- Embed content item.
- Remove content item.
Clicking Trash button on embed removes all content from block, not only embed content item. After removing embed toolbar still appears, RTE is blocked. User must click outside RTE or on Trash button again to see editor toolbar.
4) Toolbar in list block works only on list item, not whole block.
- Add list block.
- Add at least two list items.
- Click on Move Up/Move Down/ Trash Button
Action works only on list item.
5) Toolbar in list block is not fixed.
6) After adding embed item to table it is impossible to type anything.
- Add table block.
- In table embed content item
It is impossible to type anything in table, table toolbar disappears. User must click outside RTE to see table toolbar or type.
@katarzynazawada 1, 2, 3, 4, 5 - fixed (please update also branch in richtext bundle) |
@katarzynazawada please re-test is as soon as possible, as I want to merge it for beta later today. |
Checklist:
$ composer fix-cs
)