Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

EZP-29812: As an editor, I want to embed a content item within a block element #736

Merged
merged 6 commits into from
Dec 10, 2018

Conversation

dew326
Copy link
Member

@dew326 dew326 commented Dec 5, 2018

Question Answer
Tickets https://jira.ez.no/browse/EZP-29812
Requires ezsystems/ezplatform-richtext#23
Bug fix? no
New feature? yes
BC breaks? no
Tests pass? yes
Doc needed? no
License GPL-2.0

Checklist:

  • Coding standards ($ composer fix-cs)
  • Ready for Code Review
  • frontend
  • backend

Copy link

@katarzynazawada katarzynazawada left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

1) RichText Editor is not styled properly when changing block styles.

  1. Embed content.
  2. Type something.
  3. Change style (e.g Heading 1)

View before change:
image

After:
image

2) Embed content item is not visible in edit mode.

  1. Embed content.
  2. Publish.
  3. Edit.

3) Remove issue

  1. Type some text.
  2. Embed content item.
  3. Remove content item.

Clicking Trash button on embed removes all content from block, not only embed content item. After removing embed toolbar still appears, RTE is blocked. User must click outside RTE or on Trash button again to see editor toolbar.
image

In console:
image

4) Toolbar in list block works only on list item, not whole block.

  1. Add list block.
  2. Add at least two list items.
  3. Click on Move Up/Move Down/ Trash Button

Action works only on list item.

5) Toolbar in list block is not fixed.

http://recordit.co/fxulkBZnYr

6) After adding embed item to table it is impossible to type anything.

  1. Add table block.
  2. In table embed content item

It is impossible to type anything in table, table toolbar disappears. User must click outside RTE to see table toolbar or type.

@dew326
Copy link
Member Author

dew326 commented Dec 10, 2018

@katarzynazawada 1, 2, 3, 4, 5 - fixed (please update also branch in richtext bundle)
6 as discussed in private have to be done in a separate ticket (we have the same issue for the custom tags in tables)

@lserwatka
Copy link
Member

@katarzynazawada please re-test is as soon as possible, as I want to merge it for beta later today.

@lserwatka lserwatka merged commit 276b9a5 into ezsystems:master Dec 10, 2018
@alongosz alongosz deleted the embed-inline branch December 10, 2018 15:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Development

Successfully merging this pull request may close these issues.

5 participants