Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

EZP-30627: Unified Twig helpers naming #88

Merged
merged 1 commit into from
Jun 25, 2019
Merged

EZP-30627: Unified Twig helpers naming #88

merged 1 commit into from
Jun 25, 2019

Conversation

pawbuj
Copy link
Contributor

@pawbuj pawbuj commented Jun 6, 2019 •
edited by adamwojs
Loading

Question Answer
JIRA issue EZP-30627
Type Improvement
Target version master
BC breaks yes
Doc needed yes

related to ezsystems/ezplatform-admin-ui#1008

TODO:

  • Implement feature / fix a bug.
  • Implement tests + specs and passing ($ composer test)
  • Fix new code according to Coding Standards ($ composer fix-cs).
  • Ask for Code Review.

@pawbuj pawbuj self-assigned this Jun 6, 2019
andrerom
andrerom suggested changes Jun 6, 2019
View reviewed changes
Copy link
Contributor

@andrerom andrerom left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Unnecessarily BC break, -1

Maybe add alias so we can deprecate the old name over time, if the team see it as a must to enforce new rules on existing code / features.

@pawbuj
Copy link
Contributor Author

pawbuj commented Jun 7, 2019

This PR is part of biggest change , we want to clean the mess in the naming . We had a meeting and whole team decided that we make BC breaks. In our opinion it is not as problematic for developers to adapt the code to this change.

@andrerom
Copy link
Contributor

andrerom commented Jun 7, 2019

So there won't be possible to have code that works on both 2.5 and 3.0 then, not even templates?
cc @SylvainGuittard

@alongosz alongosz changed the title EZP-30627: Unify twig helpers naming EZP-30627: Unified Twig helpers naming Jun 25, 2019
@lserwatka lserwatka merged commit 01e29e4 into master Jun 25, 2019
@lserwatka lserwatka deleted the EZP-30627 branch June 25, 2019 13:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@andrerom andrerom andrerom requested changes

@adamwojs adamwojs adamwojs approved these changes

@mikadamczyk mikadamczyk mikadamczyk approved these changes

@alongosz alongosz alongosz approved these changes

@Nattfarinn Nattfarinn Awaiting requested review from Nattfarinn

@ViniTou ViniTou Awaiting requested review from ViniTou

@webhdx webhdx Awaiting requested review from webhdx

Assignees

@pawbuj pawbuj

Labels
Improvement Ready for review
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
6 participants
@pawbuj @andrerom @adamwojs @mikadamczyk @alongosz @lserwatka