Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

EZP-30627: Unified twig helpers naming #1008

Merged
merged 2 commits into from
Jun 25, 2019
Merged

EZP-30627: Unified twig helpers naming #1008

merged 2 commits into from
Jun 25, 2019

Conversation

pawbuj
Copy link
Contributor

@pawbuj pawbuj commented Jun 6, 2019

Question Answer
Tickets EZP-30627
Bug fix? no
New feature? no
BC breaks? yes
Tests pass? yes
Doc needed? yes
License GPL-2.0

renamed functions:

  • ez_path_to_locations <-- ez_path_string_to_locations
  • ez_block_value_encode <-- encode_block_value
  • ez_http_cache_tag_location <-- ez_http_tag_location
  • ez_field_encode <-- encode_field
  • ez_field_is_empty <-- ez_is_field_empty
  • ez_render_field_definition_edit <-- ez_render_fielddefinition_edit
  • ez_render_field_definition_settings <-- ez_render_fielddefinition_settings
  • ez_render_component <-- ezplatform_admin_ui_component ??
  • ez_render_component_group <-- ezplatform_admin_ui_component_group
  • ez_render_tab_group <-- ez_platform_tabs
  • ez_content_field_identifier_image_asset <-- ez_image_asset_content_field_identifier
  • ez_content_field_identifier_first_filed_image <-- ez_first_filled_image_field_identifier
  • ez_page_builder_cross_origin_helper <-- ezplatform_page_builder_cross_origin_helper

remooved functions:

  • ez_trans_prop

renamed globals:

  • ez_admin_ui_config <-- admin_ui_config
  • ezplatform <-- ezpublish

renamed filters:

  • ez_richtext_to_html5 <-- richtext_to_html5
  • ez_richtext_to_html5_edit <-- richtext_to_html5_edit

Checklist:

  • Coding standards ($ composer fix-cs)
  • Ready for Code Review

@alongosz
Copy link
Member

Quick question: when renamed admin_ui_config into ez_ui_config, what was the reason to skip admin from the name? You've probably discussed this somewhere, but I missed that ;)

@pawbuj
Copy link
Contributor Author

pawbuj commented Jun 25, 2019

That was my invention. The name was too detailed.

@alongosz alongosz changed the title EZP-30627: Unify twig helpers naming EZP-30627: Unified twig helpers naming Jun 25, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Development

Successfully merging this pull request may close these issues.

4 participants