Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

EZP-29802: Inline custom tags support #869

Merged
merged 1 commit into from
Mar 4, 2019
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 4 additions & 0 deletions src/bundle/Resources/encore/ez.js.config.js
Original file line number Diff line number Diff line change
Expand Up @@ -63,6 +63,9 @@ const alloyEditor = [
path.resolve(__dirname, '../public/js/alloyeditor/src/buttons/ez-btn-customtag.js'),
path.resolve(__dirname, '../public/js/alloyeditor/src/buttons/ez-btn-customtag-edit.js'),
path.resolve(__dirname, '../public/js/alloyeditor/src/buttons/ez-btn-customtag-update.js'),
path.resolve(__dirname, '../public/js/alloyeditor/src/buttons/ez-btn-inlinecustomtag.js'),
path.resolve(__dirname, '../public/js/alloyeditor/src/buttons/ez-btn-inlinecustomtag-edit.js'),
path.resolve(__dirname, '../public/js/alloyeditor/src/buttons/ez-btn-inlinecustomtag-update.js'),
path.resolve(__dirname, '../public/js/alloyeditor/src/toolbars/ez-add.js'),
path.resolve(__dirname, '../public/js/alloyeditor/src/plugins/ez-add-content.js'),
path.resolve(__dirname, '../public/js/alloyeditor/src/plugins/ez-move-element.js'),
Expand All @@ -83,6 +86,7 @@ const alloyEditor = [
path.resolve(__dirname, '../public/js/alloyeditor/src/toolbars/config/ez-image.js'),
path.resolve(__dirname, '../public/js/alloyeditor/src/toolbars/config/ez-image-link.js'),
path.resolve(__dirname, '../public/js/alloyeditor/src/toolbars/config/ez-custom-tag.js'),
path.resolve(__dirname, '../public/js/alloyeditor/src/toolbars/config/ez-inline-custom-tag.js'),
path.resolve(__dirname, '../public/js/alloyeditor/src/toolbars/config/ez-custom-style.js'),
];
const fieldTypes = [];
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -59,10 +59,9 @@ export default class EzBlockTextAlign extends Component {
const icon = '/bundles/ezplatformadminui/img/ez-icons.svg#' + this.props.iconName;

return (
<button className={cssClass} onClick={this.applyStyle.bind(this)}
tabIndex={this.props.tabIndex} title={this.props.label}>
<svg className='ez-icon ez-btn-ae__icon'>
<use xlinkHref={icon}></use>
<button className={cssClass} onClick={this.applyStyle.bind(this)} tabIndex={this.props.tabIndex} title={this.props.label}>
<svg className="ez-icon ez-btn-ae__icon">
<use xlinkHref={icon} />
</svg>
</button>
);
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -24,6 +24,10 @@ export default class EzBtnCustomTagEdit extends EzWidgetButton {
}, {});
}

getUpdateBtnName() {
return `ezBtn${this.customTagName.charAt(0).toUpperCase() + this.customTagName.slice(1)}Update`;
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I would create function uppercaseFirstLetter() {}

}

/**
* Lifecycle. Renders the UI of the button.
*
Expand All @@ -32,7 +36,7 @@ export default class EzBtnCustomTagEdit extends EzWidgetButton {
*/
render() {
if (this.props.renderExclusive) {
const buttonName = `ezBtn${this.customTagName.charAt(0).toUpperCase() + this.customTagName.slice(1)}Update`;
const buttonName = this.getUpdateBtnName();
const ButtonComponent = AlloyEditor[buttonName];

return <ButtonComponent values={this.getValues()} {...this.props} />;
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -16,6 +16,12 @@ export default class EzBtnCustomTagUpdate extends EzWidgetButton {
};
}

componentDidMount() {
if (!Object.keys(this.attributes).length) {
this.saveCustomTag();
}
}

/**
* Renders the text input.
*
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -4,6 +4,10 @@ import AlloyEditor from 'alloyeditor';
import EzWidgetButton from '../base/ez-widgetbutton';

export default class EzBtnCustomTag extends EzWidgetButton {
getUpdateBtnName() {
return `ezBtn${this.customTagName.charAt(0).toUpperCase() + this.customTagName.slice(1)}Update`;
}

/**
* Lifecycle. Renders the UI of the button.
*
Expand All @@ -12,7 +16,7 @@ export default class EzBtnCustomTag extends EzWidgetButton {
*/
render() {
if (this.props.renderExclusive) {
const buttonName = `ezBtn${this.customTagName.charAt(0).toUpperCase() + this.customTagName.slice(1)}Update`;
const buttonName = this.getUpdateBtnName();
const ButtonComponent = AlloyEditor[buttonName];

return <ButtonComponent createNewTag="true" values={this.values} {...this.props} />;
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -15,7 +15,7 @@ export default class EzBtnEmbedInline extends EzBtnEmbed {
* @return {Object} The content which should be rendered.
*/
render() {
const css = 'ae-button ez-btn-ae ez-btn-ae--embed';
const css = 'ae-button ez-btn-ae ez-btn-ae--embed-inline';
const label = Translator.trans(/*@Desc("Embed")*/ 'embed_btn.label', {}, 'alloy_editor');

return (
Expand Down
Original file line number Diff line number Diff line change
@@ -0,0 +1,16 @@
import PropTypes from 'prop-types';
import EzBtnCustomTagEdit from './ez-btn-customtag-edit';

export default class EzBtnInlineCustomTagEdit extends EzBtnCustomTagEdit {
getUpdateBtnName() {
return `ezBtn${this.customTagName.charAt(0).toUpperCase() + this.customTagName.slice(1)}Update`;
}
}

eZ.addConfig('ezAlloyEditor.ezBtnInlineCustomTagEdit', EzBtnInlineCustomTagEdit);

EzBtnInlineCustomTagEdit.propTypes = {
editor: PropTypes.object.isRequired,
label: PropTypes.string.isRequired,
tabIndex: PropTypes.number.isRequired,
};
Original file line number Diff line number Diff line change
@@ -0,0 +1,51 @@
import PropTypes from 'prop-types';
import EzBtnCustomTagUpdate from './ez-btn-customtag-update';

export default class EzBtnInlineCustomTagUpdate extends EzBtnCustomTagUpdate {
/**
* Creates the custom tag in AlloyEditor.
*
* @method saveCustomTag
*/
saveCustomTag() {
const { createNewTag, editor } = this.props;
const nativeEditor = editor.get('nativeEditor');
const selection = nativeEditor.getSelectedHtml();

nativeEditor.unlockSelection(true);

if (createNewTag) {
this.execCommand();
}

const widget = this.getWidget() || this.widget;
const configValues = Object.assign({}, this.state.values);

widget.setFocused(true);

if (createNewTag) {
widget.setName(this.customTagName);
widget.setWidgetContent(selection.getHtml());
widget.renderIcon();
}

widget.clearConfig();

Object.keys(this.attributes).forEach((key) => {
widget.setConfig(key, configValues[key].value);
});
}
}

eZ.addConfig('ezAlloyEditor.ezBtnInlineCustomTagUpdate', EzBtnInlineCustomTagUpdate);

EzBtnInlineCustomTagUpdate.defaultProps = {
command: 'ezinlinecustomtag',
modifiesSelection: true,
};

EzBtnInlineCustomTagUpdate.propTypes = {
editor: PropTypes.object.isRequired,
label: PropTypes.string.isRequired,
tabIndex: PropTypes.number.isRequired,
};
Original file line number Diff line number Diff line change
@@ -0,0 +1,16 @@
import PropTypes from 'prop-types';
import EzBtnCustomTag from './ez-btn-customtag';

export default class EzBtnInlineCustomTag extends EzBtnCustomTag {
getUpdateBtnName() {
return `ezBtn${this.customTagName.charAt(0).toUpperCase() + this.customTagName.slice(1)}Update`;
}
}

eZ.addConfig('ezAlloyEditor.ezBtnInlineCustomTag', EzBtnInlineCustomTag);

EzBtnInlineCustomTag.propTypes = {
editor: PropTypes.object.isRequired,
label: PropTypes.string.isRequired,
tabIndex: PropTypes.number.isRequired,
};
Loading