EZP-29802: Inline custom tags support #869
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This comment has been minimized.
This comment has been minimized.
dew326
changed the title
dew326
force-pushed
the
inline-custom-tags
branch
from
874a368 to
b022329
Compare
This comment has been minimized.
This comment has been minimized.
|
@adamwojs we need to run cs-fixer |
dew326
force-pushed
the
inline-custom-tags
branch
from
b022329 to
7155932
Compare
tischsoic
approved these changes
Mar 4, 2019
| @@ -24,6 +24,10 @@ export default class EzBtnCustomTagEdit extends EzWidgetButton { | |||
| }, {}); | |||
| } | |||
|
|
|||
| getUpdateBtnName() { | |||
| return `ezBtn${this.customTagName.charAt(0).toUpperCase() + this.customTagName.slice(1)}Update`; | |||
There was a problem hiding this comment.
I would create function uppercaseFirstLetter() {}
| @@ -5,7 +5,12 @@ | |||
| constructor() { | |||
| this.ezNamespace = 'http://ez.no/namespaces/ezpublish5/xhtml5/edit'; | |||
| this.xhtmlNamespace = 'http://www.w3.org/1999/xhtml'; | |||
| this.customTags = Object.keys(global.eZ.adminUiConfig.richTextCustomTags); | |||
| this.customTags = Object.keys(global.eZ.adminUiConfig.richTextCustomTags).filter( | |||
There was a problem hiding this comment.
customTags might be confusing, maybe notInlineCustomTags or blockCustomTags?
There was a problem hiding this comment.
But now I see that in other files we have terminology inlineCustomTag/customTag, so OK. :)
2 tasks
konradoboza
pushed a commit
to konradoboza/ezplatform-admin-ui
that referenced
this pull request
May 29, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Checklist:
$ composer fix-cs)