Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

EZP-29970: As a Developer I'd like to order components & tabs in Admin UI #783

Merged
merged 3 commits into from
Jan 18, 2019
Merged

EZP-29970: As a Developer I'd like to order components & tabs in Admin UI #783

Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
750df69
EZP-29970: As a Developer I'd like to order components and tabs in Ad…
andrerom Dec 27, 2018
8d48a37
CS
andrerom Dec 27, 2018
6f2ac16
Fix use of variable
andrerom Dec 27, 2018
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Fix use of variable
  • Loading branch information
@andrerom
andrerom committed Dec 27, 2018
commit 6f2ac16705848406100353268e012290a1ca550f
2 changes: 1 addition & 1 deletion src/bundle/DependencyInjection/Compiler/ComponentPass.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -42,7 +42,7 @@ public function process(ContainerBuilder $container): void

foreach ($tags as $tag) {
if (!isset($tag['group'])) {
throw new InvalidArgumentException($taggedServiceId, 'Tag ' . self::TAG_NAME . ' must contain "group" argument.');
throw new InvalidArgumentException($id, 'Tag ' . self::TAG_NAME . ' must contain "group" argument.');
}
$registryDefinition->addMethodCall('addComponent', [$tag['group'], $id, $serviceReference]);
}
Expand Down
2 changes: 1 addition & 1 deletion src/bundle/DependencyInjection/Compiler/TabPass.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -42,7 +42,7 @@ public function process(ContainerBuilder $container): void

foreach ($tags as $tag) {
if (!isset($tag['group'])) {
throw new InvalidArgumentException($taggedServiceId, 'Tag ' . self::TAG_NAME . ' must contain "group" argument.');
throw new InvalidArgumentException($id, 'Tag ' . self::TAG_NAME . ' must contain "group" argument.');
}
$tabRegistryDefinition->addMethodCall('addTab', [$serviceReference, $tag['group']]);
}
Expand Down