Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

EZP-29970: As a Developer I'd like to order components & tabs in Admin UI #783

Merged
merged 3 commits into from
Jan 18, 2019
Merged

EZP-29970: As a Developer I'd like to order components & tabs in Admin UI #783

merged 3 commits into from
Jan 18, 2019

Conversation

andrerom
Copy link
Contributor

@andrerom andrerom commented Dec 27, 2018 •
edited
Loading

Question Answer
Tickets https://jira.ez.no/browse/EZP-29970 Also fixes #501
Improvment yes
BC breaks? no
Tests pass? ? (maybe)
Doc needed? yes
Branch 1.4
License GPL-2.0

Avoids having to mess around with event listener, and fight ezplatform-workflow, allows to use priority for sorting.

On the nitpick side, ideally the PriorityTaggedServiceTrait should have had method giving plain id /tags structure back like findTaggedServiceIds does, to avoid the getDefinition() and getTag() call. But unless we try to contribute that...

Checklist:

  • Coding standards ($ composer fix-cs)
  • Ready for Code Review

@ezrobot

This comment has been minimized.

Sign in to view
@andrerom andrerom mentioned this pull request Jan 2, 2019
Merged
@micszo micszo self-assigned this Jan 18, 2019
@micszo micszo changed the base branch from master to 1.4 January 18, 2019 10:21
micszo
micszo approved these changes Jan 18, 2019
View reviewed changes
Copy link
Member

@micszo micszo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tested with https://github.com/ezsystems/ezplatform-workflow/pull/40.

@micszo micszo removed their assignment Jan 18, 2019
@lserwatka lserwatka merged commit 8301aba into 1.4 Jan 18, 2019
@lserwatka lserwatka deleted the EZP-29970 branch January 18, 2019 11:35
mateuszdebinski pushed a commit that referenced this pull request Feb 13, 2024
@GrabowskiM
IBX-5660: Added option to position headline items (#783)
2d46479
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ViniTou ViniTou ViniTou approved these changes

@micszo micszo micszo approved these changes

@webhdx webhdx webhdx approved these changes

@Nattfarinn Nattfarinn Nattfarinn approved these changes

@mikadamczyk mikadamczyk Awaiting requested review from mikadamczyk

Assignees
No one assigned
Labels
QA approved
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
7 participants
@andrerom @ezrobot @Nattfarinn @webhdx @micszo @ViniTou @lserwatka