Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

EZP-29450 [Behat] DateAndTimePopup problem with time interval with ce… #574

Merged
merged 1 commit into from
Jul 25, 2018
Merged

EZP-29450 [Behat] DateAndTimePopup problem with time interval with ce… #574

merged 1 commit into from
Jul 25, 2018

Conversation

m-tyrala
Copy link
Contributor

…rtain dates

Question Answer
Tickets
Bug fix? yes
New feature? no
BC breaks? no
Tests pass? yes
Doc needed? no
License GPL-2.0

Fixing the bug in calculating the time interval for date and time popup.

Checklist:

  • Coding standards ($ composer fix-cs)
  • Ready for Code Review

@m-tyrala m-tyrala requested a review from mnocon July 24, 2018 13:18
Copy link
Member

@mnocon mnocon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good catch!

@@ -64,6 +67,11 @@ public function setDate(DateTime $date, string $dateFormat = self::DATETIME_FORM
}
}

public function deleteDayFromDate(DateTime $dateTime): DateTime
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nitpick: protected would be best 😛

@micszo micszo merged commit 673d66f into ezsystems:1.2 Jul 25, 2018
@m-tyrala m-tyrala deleted the EZP-29450 branch October 16, 2018 15:10
mateuszdebinski pushed a commit that referenced this pull request Oct 25, 2022
* IBX-3750: adjusted behat tests for workflow

* Additional fixes

* added new condition for switching categories

* updated locators

* removed unused locator
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

3 participants