EZP-29449: Cannot read property 'innerHTML' of null on upload in ezimage, ezmedia & ezbinaryfile #573
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mikadamczyk
requested review from
adamwojs,
sunpietro,
Nattfarinn,
webhdx,
tischsoic,
dew326 and
ViniTou
tischsoic
approved these changes
Jul 24, 2018
dew326
requested changes
Jul 24, 2018
| @@ -37,8 +37,8 @@ | |||
| {{ form_row(form.loop, {'label_attr': {'class': 'checkbox-inline'}}) }} | |||
| </div> | |||
| <div class="ez-field-edit-preview__dimensions"> | |||
| {{ form_row(form.width) }} | |||
| {{ form_row(form.height) }} | |||
| {{ form_row(form.width, {'label_attr': {'class': 'form-control-label'}}) }} | |||
There was a problem hiding this comment.
Why in other places you changed the class and in this case you added?
dew326
approved these changes
Jul 24, 2018
adamwojs
approved these changes
Jul 24, 2018
|
@mikadamczyk please rebase with #574 🙂 |
…age, ezmedia & ezbinaryfile
micszo
approved these changes
Jul 25, 2018
|
@mikadamczyk do we also have this in master? 🙂 |
mateuszdebinski
pushed a commit
that referenced
this pull request
Oct 25, 2022
Merge branch '2.3' of ezsystems/ezplatform-admin-ui into 4.1
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Checklist:
$ composer fix-cs)