Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

CVPN-1636 Supports both ML-KEM and Kyber in server #184

Merged
merged 2 commits into from
Dec 5, 2024

Conversation

kp-thomas-yau
Copy link
Contributor

@kp-thomas-yau kp-thomas-yau commented Dec 4, 2024

Description

Add ML-KEM groups when we are compiling WolfSSL.

Server supports ML-KEM and Kyber simultaneously.

Motivation and Context

Use officially approved standard ML-KEM from NIST to strengthen security

How Has This Been Tested?

Tested with a new helium server running locally and it can connect with:

  1. Lightway C client with liboqs
  2. Lighway C client w/o liboqs
  3. New lightway rust without liboqs

Will add integration tests in helium-server once the client also migrates to ML-KEM

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)

Checklist:

  • My code follows the code style of this project.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • All active GitHub checks are passing
  • The correct base branch is being used, if not main

Compile flags configuration can be found here:
#179
@kp-thomas-yau kp-thomas-yau marked this pull request as ready for review December 4, 2024 10:23
@kp-thomas-yau kp-thomas-yau requested a review from a team as a code owner December 4, 2024 10:23
@kp-thomas-yau kp-thomas-yau force-pushed the CVPN-1636-mlkem-kyber-server branch from 1984e0d to e8dcbd0 Compare December 5, 2024 03:38
@kp-thomas-yau kp-thomas-yau merged commit 53bbe8a into main Dec 5, 2024
20 checks passed
@xv-raihaan-m xv-raihaan-m deleted the CVPN-1636-mlkem-kyber-server branch December 30, 2024 05:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants